Skip to content

Handle fallible per commitment point in channel establishment #3109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 7 commits into from
Dec 15, 2024

Add test for async open and accept channel

d1e94bd
Select commit
Loading
Failed to load commit list.
Merged

Handle fallible per commitment point in channel establishment #3109

Add test for async open and accept channel
d1e94bd
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Dec 13, 2024 in 1s

89.70% (-0.03%) compared to 1a8bf62

View this Pull Request on Codecov

89.70% (-0.03%) compared to 1a8bf62

Details

Codecov Report

Attention: Patch coverage is 83.42857% with 58 lines in your changes missing coverage. Please review.

Project coverage is 89.70%. Comparing base (1a8bf62) to head (d1e94bd).

Files with missing lines Patch % Lines
lightning/src/ln/channel.rs 84.33% 39 Missing and 8 partials ⚠️
lightning/src/ln/channelmanager.rs 88.09% 1 Missing and 4 partials ⚠️
lightning/src/ln/functional_test_utils.rs 0.00% 3 Missing ⚠️
lightning/src/util/test_utils.rs 40.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3109      +/-   ##
==========================================
- Coverage   89.73%   89.70%   -0.03%     
==========================================
  Files         130      130              
  Lines      107793   107882      +89     
  Branches   107793   107882      +89     
==========================================
+ Hits        96727    96778      +51     
- Misses       8662     8695      +33     
- Partials     2404     2409       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov