-
Notifications
You must be signed in to change notification settings - Fork 407
Stop using a constant for monitor update_id
s after closure
#3355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TheBlueMatt
merged 8 commits into
lightningdevkit:main
from
TheBlueMatt:2024-10-mon-ids-after-close
Nov 14, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1feb713
Pass the `peer_state` lock through to `update_maps_on_chan_removal`
TheBlueMatt 9f9d448
Add missing `update_maps_on_chan_removal` call in signer restore
TheBlueMatt b423a33
Avoid a `short_to_chan_info` read lock in `claim_funds_from_hop`
TheBlueMatt ebf1de5
Build `per_peer_state` immediately in `ChannelManager` deser
TheBlueMatt 6f023f8
Req the counterparty node id when claiming against a closed chan
TheBlueMatt 3f36890
Prefer to use `MonitorUpdateRegeneratedOnStartup` where possible
TheBlueMatt c99d3d7
Stop using a constant for monitor `update_id`s after closure
TheBlueMatt 4582b20
Avoid startup `PeerState` entries for peers with unfunded channels
TheBlueMatt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.