Async wallet bump #3752
Draft
Async wallet bump #3752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! I see this is a draft PR. |
joostjager
force-pushed
the
async-wallet-bump
branch
3 times, most recently
from
d9b1c75 to
873516b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3752 +/- ##
========================================
Coverage 89.53% 89.53%
========================================
Files 157 157
Lines 125310 125551 +241
Branches 125310 125551 +241
========================================
+ Hits 112192 112409 +217
- Misses 10429 10439 +10
- Partials 2689 2703 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joostjager
force-pushed
the
async-wallet-bump
branch
6 times, most recently
from
4b4b898 to
3816c66
Compare
joostjager
force-pushed
the
async-wallet-bump
branch
5 times, most recently
from
a2bd643 to
d35c1f4
Compare
To prepare for asynchronous processing of the sweep, we need to decouple the spending from the chain notifications. These notifications run in a sync context and wouldn't allow calls into an async trait. Instead we now periodically call into the sweeper, to open up the possibility to do so from an async context if desired.
synchronous wrappers for usage in a sync context.
joostjager
force-pushed
the
async-wallet-bump
branch
2 times, most recently
from
9d7dedd to
825bd10
Compare
Async closures are complicated. Preparatory commit.
Convert methods that need to be async when the wallet traits become async.
It seems that the compiler doesn't recognize the drop and complains that the mutex crosses an await (introduced in later commit), even though it doesn't.
Async closures are complicated. Preparatory commit.
joostjager
force-pushed
the
async-wallet-bump
branch
from
825bd10 to
15af397
Compare
joostjager
force-pushed
the
async-wallet-bump
branch
from
15af397 to
b96efa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3540