Skip to content

challanger: fix shutdown panic #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

challanger: fix shutdown panic #180

merged 1 commit into from
May 27, 2025

Conversation

hieblmi
Copy link
Contributor

@hieblmi hieblmi commented May 27, 2025

Seeing the following because l.invoiceCancel() isn't initialized when config strictverify isn't set.

[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x103fcf340]

goroutine 1 [running]:
github.com/lightninglabs/aperture/challenger.(*LndChallenger).Stop(0x140005fbc00)
        /Users/bob/projects/go/src/github.com/aperture/challenger/lnd.go:273 +0x20

guggero
guggero reviewed May 27, 2025
View reviewed changes
@hieblmi hieblmi force-pushed the fix-shutdown-panic branch from 1a64975 to 6ee0829 Compare May 27, 2025 18:30
@hieblmi hieblmi requested a review from guggero May 27, 2025 18:30
guggero
guggero approved these changes May 27, 2025
View reviewed changes
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@guggero guggero merged commit a990f62 into lightninglabs:master May 27, 2025
5 checks passed
@hieblmi hieblmi deleted the fix-shutdown-panic branch May 27, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guggero guggero guggero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hieblmi @guggero