lndclient: handle CloseInstant update - #244
Merged
Merged
Conversation
starius
approved these changes
Sep 11, 2025
starius
left a comment
starius
left a comment
Contributor
There was a problem hiding this comment.
LGTM! 🌿
Added a comment.
|
|
||
| // NumberOfPendingHtlcs returns the number of pending htlcs that we have | ||
| // present while a channel close with NoWait option was in progress. | ||
| func (p *ChannelClosedUpdate) NumberOfPendingHtlcs() int32 { |
Contributor
There was a problem hiding this comment.
Why is this method needed? The field is public.
Contributor
Author
There was a problem hiding this comment.
True, I added it to be consistent with CloseTxid(). I removed it.
hieblmi
force-pushed
the
no-wait-update
branch
from
September 11, 2025 18:41
160ce53 to
f9c8a9b
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitting
CloseChannelwith theNoWaitflag leads to errorThis update type was introduced as part of the NoWait channel closure implementation in lnd.