tapdb: allow reinsertion of an existing address to the book #1549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 15166568904Details
💛 - Coveralls |
ffranr
reviewed
May 20, 2025
guggero
reviewed
May 21, 2025
guggero
reviewed
May 21, 2025
Contributor
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Nice! One request and a nit, otherwise LGTM.
| -- RETURNING id to work on the existing row. | ||
| taproot_output_key = excluded.taproot_output_key | ||
| WHERE | ||
| addrs.version = excluded.version |
Contributor
There was a problem hiding this comment.
Hmm, interesting approach.
So this now returns unable to insert addr: sql: no rows in result set if some fields mismatch. Sounds good to me, but I think we should catch that on the RPC server and return a more user friendly error. Otherwise it's hard to understand what's wrong.
tapdb/addrs_test.go
Outdated
|
|
||
| // Now change the amount, which upon upsert should trigger an error. | ||
| addrs[0].Amount += 1 | ||
| require.Error(t, addrBook.InsertAddrs(ctx, addrs[0])) |
Contributor
There was a problem hiding this comment.
nit: require.ErrorIs(t, addrBook.InsertAddrs(ctx, addrs[0]), sql.ErrNoRows)?
With this change we allow "upserting" an address. This is useful in the case when a tapd user might not know if they've created a specific address already (as there's no easy way to look it up).
bhandras
changed the title
ffranr
approved these changes
May 22, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we allow "upserting" an address. This is useful in the case when a tapd user might not know if they've created a specific address already (as there's no easy way to look it up).