Skip to content

sample-tapd.conf+tapcfg: add default signet/testnet4 uni servers #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

guggero
Copy link
Member

@guggero guggero commented May 21, 2025

Uses our universe servers as proof couriers by default for the networks testnet4 and signet.

NOTE: The required CNAME entries don't exist yet (but should soon), just putting this up so we don't forget for the final release.

@coveralls
Copy link

coveralls commented May 21, 2025

Pull Request Test Coverage Report for Build 15182918524

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 40 (0.0%) changed or added relevant lines in 1 file are covered.
  • 21 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.02%) to 37.141%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tapcfg/server.go 0 40 0.0%
Files with Coverage Reduction New Missed Lines %
tappsbt/create.go 2 26.74%
asset/asset.go 3 45.46%
asset/mock.go 4 64.71%
tapdb/universe.go 4 80.4%
tapgarden/caretaker.go 8 68.31%
Totals Coverage Status
Change from base Build 15160950886: -0.02%
Covered Lines: 26998
Relevant Lines: 72690

💛 - Coveralls

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌈

Uses our universe servers as proof couriers by default for the networks
testnet4 and signet.
The ports are different from the testnet and mainnet instances because
the infrastructure was set up slightly differently.
@guggero guggero force-pushed the signet-testnet4-universes branch from b03d512 to 27c7e2d Compare May 22, 2025 09:24
@guggero
Copy link
Member Author

guggero commented May 22, 2025

The ports for testnet4 and signet actually need to be 443, since the infrastructure is set up slightly differently from the testnet and mainnet universes.

@levmi levmi moved this from 🆕 New to 🏗 In progress in Taproot-Assets Project Board May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

3 participants