itest: fix flakiness in full value send test #1944
Conversation
Remove the shared timeout context previously passed from the parent test. The context was only used for NewAddr RPC calls, which do not require explicit timeout handling as the test harness already enforces test-level timeouts. Simplify the function signature by removing the context parameter and create Background contexts locally at each call site as needed.
Replace direct QueryAddrs calls with retry-enabled logic to ensure the target address is found within the list. Prevents flakiness in test cases where the address list might not be immediately updated.
Summary of ChangesHello @ffranr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to improve the reliability of integration tests, specifically addressing flakiness in the full value send test. It resolves timing-related issues by implementing a robust retry mechanism for address lookups and streamlines context usage within the test suite for better maintainability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to fix flakiness in the full value send integration test. It achieves this by adding retry logic when querying for a newly created address, which is a solid improvement. It also simplifies context handling in the test by removing a broad timeout. My review focuses on this context handling change, suggesting the re-introduction of scoped timeouts for RPC calls to ensure test robustness against hangs.
Pull Request Test Coverage Report for Build 20858210230Details
💛 - Coveralls |
Related (but dont close yet): #1911
Summary
AssertAddrCreatedto handle race conditions when querying addresses