multi: Use Lightning Labs mainnet mempool endpoint - #1166
Conversation
Route lwwallet chain data and optional fee estimation through the Lightning Labs-operated mainnet mempool instance. Keep examples and operator documentation aligned with the new defaults.
|
/gateway review |
There was a problem hiding this comment.
Pull request overview
This PR updates Wavelength’s default mainnet Esplora and mempool.space fee-estimation endpoints to use a Lightning Labs-operated mempool instance, and aligns tests and operator documentation with the new defaults.
Changes:
- Switch mainnet defaults from public
mempool.spacetomempool.staging.lightningcluster.comfor lwwallet Esplora and recommended-fee estimates. - Update tests to assert the new defaults/URLs.
- Refresh configuration and documentation references to reflect the new default endpoints.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| waved/config_mempoolspace_fee_test.go | Updates nil-safe accessor test to use the new mainnet fee URL. |
| sample-waved.conf | Adjusts operator-facing config comments for the mempool.space fee URL default behavior. |
| lwwallet/esplora.go | Updates EsploraClient documentation to reference the new default constant. |
| lwwallet/defaults.go | Changes DefaultEsploraURLMainnet to the Lightning Labs-operated mempool instance. |
| lwwallet/defaults_test.go | Updates test doc comment to no longer claim mainnet uses public mempool.space. |
| lwwallet/config.go | Adjusts config field docs to reference DefaultEsploraURLMainnet. |
| docs/signet.md | Updates the documented mainnet lwwallet Esplora default URL. |
| chainfees/mempoolspace.go | Switches mainnet recommended-fee default to Lightning Labs-operated mempool instance. |
| chainfees/mempoolspace_test.go | Updates URL used in scheme-validation test to match the new mainnet default. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| # Override the network-default recommended-fee endpoint. Must be an absolute | ||
| # https URL. Empty uses the per-network default: public mempool.space on | ||
| # mainnet, Lightning Labs-operated mempool instances on testnet3, testnet4, | ||
| # and signet. | ||
| # https URL. Empty uses a Lightning Labs-operated mempool instance for the | ||
| # configured network. |
![lightninglabs-gateway[bot]](https://avatars.githubusercontent.com/in/3635431?s=60&v=4){kind=small}
There was a problem hiding this comment.
Gateway review — 4 findings
🔴 0 Blocker · 🟠 1 Major · 🟡 2 Minor · 🔵 1 Nit
Summary
The PR repoints the mainnet lwwallet Esplora default and the mainnet
recommended-fee default at a Lightning Labs-operated instance, so all four
supported networks now resolve to first-party infrastructure instead of
mixing in the public mempool.space host on mainnet, and updates the two
docs that enumerated the old default. The Go changes are mechanical: two
string constants plus doc-comment rewording, with the test literals swapped
to match.
The substantive question is the hostname itself. mempool.staging.lightningcluster.com
is a staging name, and on mainnet it becomes the default source for every
piece of chain data the lwwallet backend consumes — tip height, blocks,
headers, transactions, address UTXOs, fee estimates, and transaction
broadcast (lwwallet/esplora.go) — plus the fee endpoint for the lnd
backend's optional provider. None of the other three network defaults carry
a staging label; they use the same mempool-<net>.testnet.lightningcluster.com
production shape. That asymmetry is the one thing worth resolving before this
lands.
The doc updates are otherwise consistent with the code, with one
overclaiming sentence in sample-waved.conf.
Bot commands
/gateway re-review— re-run after pushing changes (maintainers)/gateway dismiss <id>— silence a finding (maintainers)/gateway explain <id>— elaborate on a finding (anyone)
| DefaultEsploraURLMainnet = "https://mempool.space/api" | ||
| // DefaultEsploraURLMainnet is the Esplora-compatible REST API for | ||
| // mainnet, backed by a Lightning Labs-operated mempool instance. | ||
| DefaultEsploraURLMainnet = "https://mempool.staging." + |
There was a problem hiding this comment.
🟠 F1 (Major) — Mainnet default points at a staging endpoint · lwwallet/defaults.go:13
The mainnet default for all lwwallet chain access is now a host explicitly named staging. If that instance is a staging deployment in the usual sense — lower capacity, no production SLA, redeployed at will — then every mainnet waved instance that leaves wallet.esploraurl empty loses tip polling, UTXO discovery, and transaction broadcast whenever it is cycled, and this is the network where real funds are at stake.
Why this matters
The same host lands in chainfees/mempoolspace.go:37 for the mainnet recommended-fee endpoint, so a staging outage degrades both chain data and fee estimation on mainnet simultaneously. Note the naming asymmetry against the other defaults in this same const block: testnet3, testnet4, and signet all use mempool-<net>.testnet.lightningcluster.com, a production-shaped name, while mainnet alone gets a staging subdomain. readme states mainnet operation is gated behind --allow-mainnet and that the project is under active development, which lowers the blast radius today but does not make a staging host the right value to bake in as the mainnet default. Either point mainnet at the production name, or, if mempool.staging.… is in fact the durable production endpoint that merely carries a legacy label, say so in the constant's doc comment so the next reader does not have to guess. I cannot tell from the diff or the loaded context which of the two it is.
| # mainnet, Lightning Labs-operated mempool instances on testnet3, testnet4, | ||
| # and signet. | ||
| # https URL. Empty uses a Lightning Labs-operated mempool instance for the | ||
| # configured network. |
There was a problem hiding this comment.
🟡 F2 (Minor) — Config comment claims a default for networks that have none · sample-waved.conf:228
The new text — "Empty uses a Lightning Labs-operated mempool instance for the configured network" — reads as though every network has a default, but DefaultMempoolSpaceURL (chainfees/mempoolspace.go) returns unsupported mempool.space network %q for regtest and simnet, so an empty URL there fails estimator construction rather than resolving to anything. The text this replaces enumerated the networks explicitly and did not have that gap; keeping the enumeration preserves the information the operator needs.
| # configured network. | |
| # configured network on mainnet, testnet3, testnet4, and signet. |
| { | ||
| name: "https ok", | ||
| url: "https://mempool.space/api/v1/fees/recommended", | ||
| url: mempoolSpaceMainnetURL, |
There was a problem hiding this comment.
🟡 F3 (Minor) — Only positive https case in the validator test now tracks the constant · chainfees/mempoolspace_test.go:232
TestMempoolSpaceEstimatorRejectsInsecureURL's "https ok" row was the table's only fixed positive case for the https-accept path in validateMempoolSpaceURL; binding it to mempoolSpaceMainnetURL means the case's input now moves whenever the default moves, and the row's name stops describing what it pins. Keep the literal https:// case and add a separate row asserting the mainnet default also validates — that covers both the validator and the constant, instead of trading one for the other.
| func TestMempoolSpaceFeeAccessorsAreNilSafe(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| const mainnetURL = "https://mempool.staging.lightningcluster.com/" + |
There was a problem hiding this comment.
🔵 F4 (Nit) — Test duplicates the production mainnet URL it does not assert on · waved/config_mempoolspace_fee_test.go:26
TestMempoolSpaceFeeAccessorsAreNilSafe only checks that MempoolSpaceFeeURL() round-trips whatever was set, so the value is arbitrary; hardcoding a copy of the real mainnet endpoint (which the waved package cannot reference, since the chainfees constant is unexported) creates a literal that will silently drift from production without any test noticing. An obviously-synthetic URL makes the test's indifference to the value explicit.
|
🤖 gateway audit metadata for this PR — auto-generated, please don't edit. |
|
With this I'm not hitting |
sputn1ck
added
the
backport-v0.1.x-branch
|
Successfully created backport PR for |
…ranch [v0.1.x-branch] Backport #1166: multi: Use Lightning Labs mainnet mempool endpoint
|
Great work 💯 |
Summary
mempool.staging.lightningcluster.comTesting
make lint-changed-localmake unit pkg=chainfees case=TestDefaultMempoolSpaceURLmake unit pkg=lwwallet case=TestDefaultEsploraURLmake unit pkg=waved case=TestMempoolSpaceFeeAccessorsAreNilSafemake unit pkg=waved case=TestConfigValidateWalletDefaults/api/blocks/tip/heightand/api/v1/fees/recommended