Skip to content

ci: add claude PR review workflow using differential-review skill#10654

Open
ziggie1984 wants to merge 1 commit intolightningnetwork:masterfrom
ziggie1984:claude-review-workflow
Open

ci: add claude PR review workflow using differential-review skill#10654
ziggie1984 wants to merge 1 commit intolightningnetwork:masterfrom
ziggie1984:claude-review-workflow

Conversation

@ziggie1984
Copy link
Collaborator

Summary

  • Adds claude-review.yml workflow triggered by @claude review comments on PRs
  • Uses the differential-review skill from lightninglabs/agent-skills, cloned at runtime
  • Pins to anthropics/claude-code-action#963 fix commit to correctly handle fork PRs (the current @v1 fails with fatal: couldn't find remote ref on fork branches)
  • Excludes @claude review from claude.yml to prevent both workflows firing on the same comment
  • Includes workflow_dispatch for testing the workflow on this branch before merging

Test plan

  • Manually trigger via Actions → Claude PR Review → Run workflow on this branch with a PR number
  • Verify agent-skills clones correctly and differential-review skill is loaded
  • Comment @claude review on a fork PR and confirm it doesn't hit the branch fetch error
  • Remove workflow_dispatch block before final merge

@gemini-code-assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Copy link
Collaborator

@saubyk saubyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one clarification

runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: write
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarification: Does Claude need 'write' permission to post review comments on the issue or pr?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it is needed

@ziggie1984 ziggie1984 force-pushed the claude-review-workflow branch 2 times, most recently from 4c46aea to 883f5c6 Compare March 23, 2026 17:46
Adds a dedicated claude-review.yml workflow that triggers on '@claude review'
comments and runs the differential-review skill from lightninglabs/agent-skills.

Uses the fix commit from anthropics/claude-code-action#963 to handle fork PRs
correctly (refs/pull/N/head instead of fetching by branch name from origin).

Also excludes '@claude review' from the general-purpose claude.yml to prevent
both workflows from firing on the same comment.

Includes a workflow_dispatch trigger for testing before merging.
@ziggie1984 ziggie1984 force-pushed the claude-review-workflow branch from 883f5c6 to 86e3a2a Compare March 23, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants