Skip to content

peer: fix flaky nil pointer dereference in PingManager #10660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ellemouton wants to merge 2 commits into
base: master
Choose a base branch
from
Open

peer: fix flaky nil pointer dereference in PingManager #10660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a2c4c6
peer: fix nil deref in newPingPayload on BestBlockHeader error
ellemouton Mar 24, 2026
d408966
peer: add mock BestBlockView to test peer config
ellemouton Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion peer/brontide.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,7 +734,7 @@ func NewBrontide(cfg Config) *Brontide {
// used to cross-check our own view of the network to mitigate
// various types of eclipse attacks.
header, err := p.cfg.BestBlockView.BestBlockHeader()
if err != nil && header == lastBlockHeader {
if err != nil || header == lastBlockHeader {
return lastSerializedBlockHeader[:]
}

Expand Down
17 changes: 16 additions & 1 deletion peer/test_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,20 @@ func (m *mockMessageConn) Close() error {
return nil
}

// mockBestBlockView is a mock implementation of chainntnfs.BestBlockView for
// testing.
type mockBestBlockView struct{}

// BestHeight returns a dummy block height.
func (m *mockBestBlockView) BestHeight() (uint32, error) {
return 0, nil
}

// BestBlockHeader returns a dummy block header.
func (m *mockBestBlockView) BestBlockHeader() (*wire.BlockHeader, error) {
return &wire.BlockHeader{}, nil
}

// createTestPeer creates a new peer for testing and returns a context struct
// containing necessary handles and mock objects for conducting tests on peer
// functionalities.
Expand Down Expand Up @@ -739,7 +753,8 @@ func createTestPeer(t *testing.T) *peerTestCtx {

return nil
},
PongBuf: make([]byte, lnwire.MaxPongBytes),
PongBuf: make([]byte, lnwire.MaxPongBytes),
BestBlockView: &mockBestBlockView{},
FetchLastChanUpdate: func(chanID lnwire.ShortChannelID,
) (*lnwire.ChannelUpdate1, error) {

Expand Down
Loading