Skip to content

lntest: disable bitcoind v2 P2P transport in itests #10661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ellemouton wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −0
Open

lntest: disable bitcoind v2 P2P transport in itests #10661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lntest/bitcoind_common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,14 @@ func newBackend(miner string, netParams *chaincfg.Params, extraArgs []string,
"-debuglogfile=" + logFile,
"-blockfilterindex",
"-peerblockfilters",
// Disable v2 transport since the miner is btcd, which
// doesn't support v2 yet. Without this, bitcoind
// attempts a v2 handshake that hangs for 30s before
// falling back to v1, causing test flakes whenever a
// test reconnects to the miner under a timeout.
//
// TODO: Remove once btcd supports v2 P2P transport.
"-v2transport=0",
}
cmdArgs = append(cmdArgs, extraArgs...)
bitcoind := exec.Command("bitcoind", cmdArgs...)
Expand Down
7 changes: 7 additions & 0 deletions lntest/miner/bitcoind_miner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,13 @@ func (b *BitcoindMinerBackend) Start(setupChain bool,
"-debuglogfile=" + logFile,
// Set fallback fee for transaction creation.
"-fallbackfee=0.00001",
// Disable v2 transport since this backend may peer with
// btcd nodes that don't support v2 yet. Without this,
// bitcoind attempts a v2 handshake that hangs for 30s
// before falling back to v1.
//
// TODO: Remove once btcd supports v2 P2P transport.
"-v2transport=0",
}

cmdArgs = append(cmdArgs, b.extraArgs...)
Expand Down
Loading