Skip to content

Included codeql action to improve the security #5735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

naveensrinivasan
Copy link
Contributor

@naveensrinivasan naveensrinivasan commented Sep 15, 2021

Pull Request Checklist

  • All changes are Go version 1.15 compliant
  • Your PR passes all CI checks. If a check cannot be passed for a justifiable reason, that reason must be stated in the commit message and PR description.
  • If this is your first time contributing, we recommend you read the Code Contribution Guidelines
  • For new code: Code is accompanied by tests which exercise both the positive and negative (error paths) conditions (if applicable)
  • For bug fixes: If possible, code is accompanied by new tests which trigger the bug being fixed to prevent regressions
  • Any new logging statements use an appropriate subsystem and logging level
  • For code and documentation: lines are wrapped at 80 characters (the tab character should be counted as 8 characters, not 4, as some IDEs do per default)
  • A description of your changes should be added to running the release notes for the milestone your change will land in.

The actions reference are pinned by SHA so these cannot be compromised.

Permission for these actions is restricted.

 # required for all workflows
      security-events: write

      # only required for workflows in private repositories
      actions: read
      contents: read

@orijbot
Copy link

orijbot commented Sep 15, 2021

@Roasbeef Roasbeef added github actions golang/build system Related to the go language and compiler security General label for issues/PRs related to the security of the software labels Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github actions golang/build system Related to the go language and compiler security General label for issues/PRs related to the security of the software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants