[4/7] multi: continue threading the new interfaces #8253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
force-pushed
the
g175-thread-interfaces-2
branch
from
5ab6876 to
74e232b
Compare
ellemouton
changed the base branch from
master
to
elle-g175-thread-interfaces-1
ellemouton
force-pushed
the
elle-g175-thread-interfaces-1
branch
from
73b8186 to
e6ea852
Compare
ellemouton
force-pushed
the
g175-thread-interfaces-2
branch
from
74e232b to
71e245c
Compare
|
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
With a migration to migrate existing entries in the waiting proof store to use a type byte prefix.
ellemouton
force-pushed
the
g175-thread-interfaces-2
branch
from
71e245c to
183d184
Compare
ellemouton
force-pushed
the
elle-g175-thread-interfaces-1
branch
from
e6ea852 to
fea428d
Compare
Roasbeef
requested changes
Sep 19, 2024
|
|
||
| case *lnwire.ChannelAnnouncement2: | ||
| return &models.ChannelAuthProof2{ | ||
| SchnorrSigBytes: a.Signature.ToSignatureBytes(), |
| err := fn.MapOptionZ(newSchema.InboundFee, | ||
| func(f models.InboundFee) error { | ||
| inboundWireFee := f.ToWire() | ||
| return edge.ExtraOpaqueData.PackRecords( |
There was a problem hiding this comment.
Can just put inline within the message now.
|
|
||
| // WaitingProofInterface is an interface that must be implemented by any waiting | ||
| // proof to be stored in the waiting proof DB. | ||
| type WaitingProofInterface interface { |
| @@ -286,6 +287,10 @@ var ( | |||
| number: 31, | |||
| migration: migration31.DeleteLastPublishedTxTLB, | |||
| }, | |||
| { | |||
| number: 32, | |||
| migration: migration32.MigrateWaitingProofStore, | |||
There was a problem hiding this comment.
Could consider partitioning here as well?
| // AggregateNonce is an optional field that lets the gossiper know of the | ||
| // aggregate nonce used in the construction of the channel announcement | ||
| // signature. | ||
| func AggregateNonce(nonce *btcec.PublicKey) OptionalMsgField { |
There was a problem hiding this comment.
Combined nonces in musig2 are 66 bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the Gossip 1.75 epic.
Depends on #8252 so only the last 7 commits are new
In this PR, we continue threading the new interfaces throughout the code base.
The following major things are done here:
handleAnnSiguse the newlnwire.AnnounceSigsinterface