[5/7]: multi: thread ChannelUpdate through codebase #8254

ellemouton · 2023-12-06T13:41:29Z

Depends on #8252 so only the last 14 commits are new

In this PR, we continue threading the new interfaces throughout the code base.
All that is done here is the threading of the new lnwire.ChannelUpdate interface through
the code base. It is split into multiple commits for easier review.

coderabbitai · 2024-02-12T13:31:08Z

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

In this commit, we pass the MessageSignerRing around in places where Schnorr signing will be needed to sign Gossip 1.75 messages.

Update the ChannelUpdate modifiers to use the lnwire.ChannelUpdate interface instead of *lnwire.ChannelUpdate1.

...interface instead of ChannelUpdate1.

In the IsKeepAlive and IsStaleEdgePolicy functions

Roasbeef · 2024-09-23T06:35:28Z

keychain/derivation.go

+	// SignMessageSchnorr signs the given message, single or double SHA256
+	// hashing it first, with the private key described in the key locator
+	// and the optional Taproot tweak applied to the private key.
+	SignMessageSchnorr(keyLoc KeyLocator, msg []byte, doubleHash bool,


This is the SingleKeyMessageSigner (bound to a single pubkey), why does it need to accept a KeyLocator? I think you instead want MessageSignerRing if you wnat to be able to pass in ahother keyloc.

Roasbeef · 2024-09-23T06:38:19Z

discovery/gossiper.go

@@ -337,8 +336,7 @@ type Config struct {

 	// SignAliasUpdate is used to re-sign a channel update using the
 	// remote's alias if the option-scid-alias feature bit was negotiated.
-	SignAliasUpdate func(u *lnwire.ChannelUpdate1) (*ecdsa.Signature,
-		error)
+	SignAliasUpdate func(u lnwire.ChannelUpdate) error


Should update the godoc, as IIUC now the sig will only be set in place instead of also being returned.

Roasbeef · 2024-09-23T06:38:34Z

htlcswitch/switch.go

@@ -221,8 +220,7 @@ type Config struct {
 	// option_scid_alias channels. This avoids a potential privacy leak by
 	// replacing the public, confirmed SCID with the alias in the
 	// ChannelUpdate.
-	SignAliasUpdate func(u *lnwire.ChannelUpdate1) (*ecdsa.Signature,
-		error)
+	SignAliasUpdate func(u lnwire.ChannelUpdate) error


Same here re godoc.

Roasbeef · 2024-09-23T06:40:27Z

discovery/gossiper_test.go

+		case *models.ChannelEdgePolicy1:
+			return !timestamp.After(edge.LastUpdate)
+		default:
+			panic(fmt.Sprintf("unhandled: %T", edges[1]))


What about the chan upd2 case?

Roasbeef · 2024-09-23T06:50:17Z

lnrpc/routerrpc/router_backend.go

 		response.Code = lnrpc.Failure_EXPIRY_TOO_SOON
-		response.ChannelUpdate = marshallChannelUpdate(&onionErr.Update)
+		response.ChannelUpdate = update1
+		response.ChannelUpdate_2 = update2


See comment on prior PR, I think we can just merge the two protos, and add a type field. This way clients will just work if they're wanting to consume updates over the streaming RPC.

Roasbeef · 2024-09-23T06:58:44Z

discovery/gossiper.go

-	flags lnwire.ChanUpdateChanFlags
+	disabled bool
+
+	direction bool


Missing godoc comment.

Roasbeef · 2024-09-23T06:59:37Z

discovery/gossiper.go

 		}

-		oldTimestamp := uint32(0)
+		var (
+			older = false


Roasbeef · 2024-09-23T07:02:10Z

graph/builder.go

+		height := upd.BlockHeight
+
+		edge1Height, edge2Height, exists, isZombie, err :=
+			b.cfg.Graph.HasChannelEdge2(chanID.ToUint64())


I think if we can come up with an abstraction over the return values here (height vs timestamp), then we can condense this function a bit and eliminate some of the duplication.

Roasbeef · 2024-09-23T07:03:47Z

discovery/gossiper.go

@@ -3848,6 +3876,39 @@ func (d *AuthenticatedGossiper) ShouldDisconnect(pubkey *btcec.PublicKey) (
 	return false, nil
 }

+func (d *AuthenticatedGossiper) updateWithinRebroadcastInterval(


Missing godoc comment.

ellemouton added the gossip label Dec 6, 2023

ellemouton marked this pull request as draft December 6, 2023 13:41

ellemouton mentioned this pull request Dec 6, 2023

[epic]: Gossip 1.75 #7961

Open

21 tasks

ellemouton force-pushed the g175-thread-chan-update branch from c76c05b to 96afa6e Compare January 11, 2024 15:28

ellemouton changed the base branch from master to elle-g175-thread-interfaces-2 January 11, 2024 15:29

ellemouton force-pushed the elle-g175-thread-interfaces-2 branch from 74e232b to 71e245c Compare February 12, 2024 13:28

ellemouton force-pushed the g175-thread-chan-update branch from 96afa6e to 5c11c93 Compare February 12, 2024 13:30

saubyk assigned ellemouton Jun 27, 2024

ellemouton added 15 commits September 2, 2024 14:12

netann: give ChanStatusManager access to BestBlockView

62a2f64

multi: use MessageSignerRing where needed

dbbf84a

In this commit, we pass the MessageSignerRing around in places where Schnorr signing will be needed to sign Gossip 1.75 messages.

netann: update ChanUpdate modifiers to use interface

c4ad342

Update the ChannelUpdate modifiers to use the lnwire.ChannelUpdate interface instead of *lnwire.ChannelUpdate1.

netann: let SignChannelUpdate take ChannelUpdate interface

a5afcd2

multi: update SignAliasUpdate to take ChannelUpdate interface

0b964d8

routing: update to use lnwire.ChannelUpdate interface

43de450

multi: let some netann funcs use lnwire.ChannelUpdate

72e8b90

...interface instead of ChannelUpdate1.

multi: use ChannelUpdate interface for failure messages

40981df

htlcswitch: let failAliasUpdate return lnwire.ChannelUpdate

e749a44

htlcswitch: use ChannelUpdate interface in FetchLastChannelUpdate

77df834

netann: use ChannelUpdate interface in ExtractChannelUpdate

ad0de06

multi: use ChannelUpdate interface in various places

cdcf0ac

discovery+routing: update to use ChanUpdate interface

58d4518

In the IsKeepAlive and IsStaleEdgePolicy functions

discovery: use ChannelUpdate interface in handleChanUpdate

fc4e28f

docs: add release notes

e1b873e

ellemouton force-pushed the g175-thread-chan-update branch from 5c11c93 to e1b873e Compare September 3, 2024 11:15

ellemouton force-pushed the elle-g175-thread-interfaces-2 branch from 71e245c to 183d184 Compare September 3, 2024 11:17

Roasbeef requested changes Sep 23, 2024

View reviewed changes

saubyk added this to the 0.20.0 milestone Dec 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[5/7]: multi: thread ChannelUpdate through codebase #8254

[5/7]: multi: thread ChannelUpdate through codebase #8254

ellemouton commented Dec 6, 2023

coderabbitai bot commented Feb 12, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Roasbeef Sep 23, 2024

Roasbeef Sep 23, 2024

Roasbeef Sep 23, 2024

Roasbeef Sep 23, 2024

Roasbeef Sep 23, 2024

Roasbeef Sep 23, 2024

Roasbeef Sep 23, 2024

Roasbeef Sep 23, 2024

Roasbeef Sep 23, 2024

[5/7]: multi: thread ChannelUpdate through codebase #8254

Are you sure you want to change the base?

[5/7]: multi: thread ChannelUpdate through codebase #8254

Conversation

ellemouton commented Dec 6, 2023

coderabbitai bot commented Feb 12, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coderabbitai bot commented Feb 12, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)