[6/7]: discovery: sync gossip using block heights & ranges #8255

ellemouton · 2023-12-06T13:42:07Z

This is part of the Gossip 1.75 epic.

Depends on #8164 so only the last 4 commits are new

In this PR, we make use of the new StartHeight and BlockRange fields in the GossipTimestampRange message.

coderabbitai · 2024-02-12T13:30:49Z

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

So that a start block and end block can also be passed in.

Roasbeef · 2024-09-23T07:06:32Z

discovery/syncer.go

+		startBlock tlv.RecordT[tlv.TlvType2, uint32]
+		endBlock   tlv.RecordT[tlv.TlvType4, uint32]
+	)
+	startBlock = g.remoteUpdateHorizon.FirstBlockHeight.UnwrapOr(startBlock)


Perhaps we just want to make an UnwrapOrV? Similar to WhenSomeV it will call Val for you, so then we cna just pass in the two timestamps above.

We may also want consider making a type alias for tlv.RecordT[tlv.TlvType2, uint32], so then it can just be lnwire.ChanUpdStartBlock (or something like that).

Roasbeef · 2024-09-23T07:08:22Z

channeldb/graph.go

+			tx, edges, edgeIndex, nodes, edgeUpdateIndexBucket,
+			startTimeBytes[:], endTimeBytes[:],
+			func(key []byte) []byte {
+				return key[8:]


Let's throw up these magic numbers into top level constants.

Roasbeef · 2024-09-23T07:08:43Z

channeldb/graph.go

+			return err
+		}
+
+		var startBlockBytes, endBlockBytes [4 + 8]byte


Same here re the key lengths.

Roasbeef · 2024-09-23T07:09:27Z

graph/interfaces.go

@@ -147,8 +147,8 @@ type DB interface {
 	// ChanUpdatesInHorizon returns all the known channel edges which have
 	// at least one edge that has an update timestamp within the specified
 	// horizon.
-	ChanUpdatesInHorizon(startTime, endTime time.Time) (
-		[]channeldb.ChannelEdge, error)
+	ChanUpdatesInHorizon(startTime, endTime time.Time, startBlock,


Is the expectation that both the timestamp and block are always set now? If only one of them is expecting, we may wan tto rol that into a new struct to better convey that with types.

Roasbeef · 2024-09-23T07:10:16Z

discovery/syncer.go

@@ -690,12 +694,23 @@ func (g *GossipSyncer) replyHandler() {
 // sendGossipTimestampRange constructs and sets a GossipTimestampRange for the
 // syncer and sends it to the remote peer.
 func (g *GossipSyncer) sendGossipTimestampRange(firstTimestamp time.Time,
-	timestampRange uint32) error {
+	timestampRange uint32, firstBlock, blockRange *uint32) error {


Opt instead of the pointer?

ellemouton changed the title ~~[6/7~~ [6/7]: discovery: sync gossip using block heights & ranges Dec 6, 2023

ellemouton added the gossip label Dec 6, 2023

ellemouton marked this pull request as draft December 6, 2023 13:44

This was referenced Dec 6, 2023

[7/7] g175: funding, feature bit & itests #8256

Draft

[epic]: Gossip 1.75 #7961

Open

ellemouton force-pushed the g175-gossip-sync branch from 5d2291b to 0af66d8 Compare January 11, 2024 15:29

ellemouton changed the base branch from master to elle-g175-thread-chan-update January 12, 2024 06:31

ellemouton force-pushed the elle-g175-thread-chan-update branch from 96afa6e to 5c11c93 Compare February 12, 2024 13:28

ellemouton force-pushed the g175-gossip-sync branch from 0af66d8 to 5246374 Compare February 12, 2024 13:30

saubyk assigned ellemouton Jun 27, 2024

ellemouton added 5 commits September 2, 2024 14:12

discovery: Filter ChanUpdate2 messages

deb4c2b

channeldb: Update ChanUpdatesInHorizon

c248f60

So that a start block and end block can also be passed in.

discovery: update UpdatesInHorizon

332cad3

discovery: start sending block heights in range query

6e8d8e1

docs: update release notes

d95e2f3

ellemouton force-pushed the g175-gossip-sync branch from 5246374 to d95e2f3 Compare September 3, 2024 11:15

ellemouton force-pushed the elle-g175-thread-chan-update branch from 5c11c93 to e1b873e Compare September 3, 2024 11:17

Roasbeef requested changes Sep 23, 2024

View reviewed changes

saubyk added this to the 0.20.0 milestone Dec 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[6/7]: discovery: sync gossip using block heights & ranges #8255

[6/7]: discovery: sync gossip using block heights & ranges #8255

ellemouton commented Dec 6, 2023 •

edited

Loading

coderabbitai bot commented Feb 12, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Roasbeef Sep 23, 2024

Roasbeef Sep 23, 2024

Roasbeef Sep 23, 2024

Roasbeef Sep 23, 2024

Roasbeef Sep 23, 2024

[6/7]: discovery: sync gossip using block heights & ranges #8255

Are you sure you want to change the base?

[6/7]: discovery: sync gossip using block heights & ranges #8255

Conversation

ellemouton commented Dec 6, 2023 • edited Loading

coderabbitai bot commented Feb 12, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Roasbeef Sep 23, 2024

Choose a reason for hiding this comment

Roasbeef Sep 23, 2024

Choose a reason for hiding this comment

Roasbeef Sep 23, 2024

Choose a reason for hiding this comment

Roasbeef Sep 23, 2024

Choose a reason for hiding this comment

Roasbeef Sep 23, 2024

Choose a reason for hiding this comment

ellemouton commented Dec 6, 2023 •

edited

Loading

coderabbitai bot commented Feb 12, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)