Skip to content

routerrpc: reject payment to invoice that don't have payment secret or blinded paths #9752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

routerrpc: reject payment to invoice that don't have payment secret or blinded paths #9752

wants to merge 2 commits into from

Conversation

erickcestari
Copy link

@erickcestari erickcestari commented Apr 22, 2025 •
edited
Loading

This PR introduces the initial phase of enforcing payment secret validation for invoices, as described in issue #9718.

Reject a payment to invoice that don't have a payment secret.

Change Description

Adds validation to extractIntentFromSendRequest to ensure that an invoice includes either a payment address (payment secret) or at least one blinded path when parsing the SendRequest details.

Related to: #9700, #9718

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 22, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@erickcestari erickcestari force-pushed the reject-payment-without-invoice branch 2 times, most recently from ada4d4e to 69e180c Compare April 22, 2025 17:32
@erickcestari erickcestari marked this pull request as draft April 22, 2025 18:01
@erickcestari erickcestari force-pushed the reject-payment-without-invoice branch 2 times, most recently from 670fca4 to b37fe55 Compare April 22, 2025 18:17
@erickcestari erickcestari changed the title cmd/payments: reject invoices without payment secret or blinded paths routerrpc: reject invoices without payment secret or blinded paths Apr 22, 2025
@erickcestari erickcestari changed the title routerrpc: reject invoices without payment secret or blinded paths routerrpc: reject payment to invoice that don't have payment secret or blinded paths Apr 22, 2025
@erickcestari erickcestari force-pushed the reject-payment-without-invoice branch from b37fe55 to bb59d52 Compare April 22, 2025 18:21
@erickcestari erickcestari marked this pull request as ready for review April 22, 2025 18:24
MPins
MPins reviewed Apr 23, 2025
View reviewed changes
Copy link
Contributor

@MPins MPins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @erickcestari, could you please split the commit into two? One for the code changes and another for the documentation. Thanks!

@erickcestari erickcestari force-pushed the reject-payment-without-invoice branch from bb59d52 to 50cc265 Compare April 24, 2025 14:06
@saubyk saubyk moved this to Medium Priority in PR Review Priority Apr 24, 2025
@saubyk saubyk added payments Related to invoices/payments invoices labels Apr 24, 2025
@saubyk saubyk added this to the v0.20.0 milestone Apr 24, 2025
MPins
MPins reviewed May 1, 2025
View reviewed changes
Copy link
Contributor

@MPins MPins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @erickcestari , consider adding a test case to TestExtractIntentFromSendRequest in router_backend_test.go to cover this scenario.

@erickcestari erickcestari force-pushed the reject-payment-without-invoice branch from 50cc265 to 6e7034a Compare May 1, 2025 12:59
MPins
MPins reviewed May 1, 2025
View reviewed changes
Copy link
Contributor

@MPins MPins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s all from my side.

@erickcestari erickcestari force-pushed the reject-payment-without-invoice branch from 6e7034a to 2395167 Compare May 1, 2025 17:20
@erickcestari
routerrpc: reject payment to invoice that don't have payment secret o…
6efacd6 
…r blinded paths

Ensure that a payment is only sent if the invoice includes either a
payment address (payment secret) or at least one blinded path.
@erickcestari
docs: add release notes for 9752
51b1059
@erickcestari erickcestari force-pushed the reject-payment-without-invoice branch from 2395167 to 51b1059 Compare May 1, 2025 17:22
@MPins
Copy link
Contributor

MPins commented May 2, 2025

Hello @saubyk it would be nice to have the CI Workflow running for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MPins MPins MPins left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@erickcestari erickcestari

Labels
invoices payments Related to invoices/payments
Projects
PR Review Priority
Status: Medium Priority
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@erickcestari @MPins @saubyk