make: allow skipping the vendor and source packaging #9807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
When you want to cross compile locally via docker it is very convenient to skip the vendor and sourcd packaging to save time.
ziggie1984
force-pushed
the
skip-vendor-and-source-packaging-cross-builds
branch
from
a5ea01e to
d2c99b4
Compare
|
@guggero: review reminder |
guggero
requested changes
May 22, 2025
There was a problem hiding this comment.
My counter suggestion, purely in the Makefile:
#? cross-release-install: Build lnd and lncli release binaries for all supported platforms to /tmp (useful for checking cross compilation or priming release build cache)
cross-release-install:
@$(call print, "Cross compiling release lnd and lncli.")
for sys in $(BUILD_SYSTEM); do \
echo "Building lnd and lncli for $$sys"; \
export CGO_ENABLED=0 GOOS=$$(echo $$sys | cut -d- -f1) GOARCH=$$(echo $$sys | cut -d- -f2); \
if [ "$$GOARCH" = "armv6" ]; then \
export GOARCH=arm; GOARM=6; \
elif [ "$$GOARCH" = "armv7" ]; then \
export GOARCH=arm; GOARM=7; \
fi; \
$(GOBUILD) -trimpath -ldflags="$(RELEASE_LDFLAGS)" -tags="$(RELEASE_TAGS)" -o /tmp/lnd-$$sys $(PKG)/cmd/lnd; \
$(GOBUILD) -trimpath -ldflags="$(RELEASE_LDFLAGS)" -tags="$(RELEASE_TAGS)" -o /tmp/lncli-$$sys $(PKG)/cmd/lncli; \
echo; \
doneFeel free to use without attribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you want to cross compile locally via docker it is very
convenient to skip the vendor and sourcd packaging to save time.