Refactor Payment PR 3 #9844
Open
Refactor Payment PR 3 #9844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ziggie1984
force-pushed
the
refactor-payments-code-03
branch
from
50f580b to
90108ed
Compare
ziggie1984
force-pushed
the
refactor-payments-code-03
branch
from
90108ed to
daced8b
Compare
In the following commits we will gradually unify the current payment db operations into an interface to later down the road support both backends (sql+kv).
We move all code from the payment_control.go into payments.go so that for later commits we can easily have all payment db related kv db code together.
We also addd this new db on the server level to use it in the following commit to do all the payment related queries of the rpcserver. We add a new payment db instance on the server level. Which we will you for the payment related queries in a following commit.
All interactions related to the payment db are now part of the kvPaymentDB struct.
ziggie1984
force-pushed
the
refactor-payments-code-03
branch
2 times, most recently
from
8658c85 to
b308ed0
Compare
We add a context for the query method because the query method will be part of the paymentDB interface and for the SQL case we need the context for this method. So we add it here as well although it is not used similar to the invoice design.
We add a new payments package and create a db interface for the paymentDB there. This is already implemented for the KV db side and will be implemented for the SQL side in future PRS.
ziggie1984
force-pushed
the
refactor-payments-code-03
branch
from
b308ed0 to
3a573e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #9825 and #9826
We introduce the new package
paymentsand add a new paymentDB interface which is already implemented on the kvdb side via KVPaymentDB.