-
Notifications
You must be signed in to change notification settings - Fork 2.2k
gomod: update btcwallet
to fix FetchOutpointInfo
#9854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Move bumpfee RPC related tests into one file - these tests focus on testing the behaivor of the RPC only without any force close context.
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending linter errors and dependant PR in btcwallet
require.ErrorContains(ht, err, "does not belong to the wallet") | ||
|
||
// Clean up the mempool. | ||
ht.MineBlocksAndAssertNumTxes(1, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if this can be done by the cleanup function of the harness ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't think so - we don't know the num of txns beforehand - and it's already done in the cleanup in the sense that we assert the mempool being empty.
Depends on,
FetchOutpointInfo
btcsuite/btcwallet#1011Also added a new test to check the underlying behavior - when an external utxo whose txid is known to the wallet, the wallet will stop considering it as an internal utxo.