-
Notifications
You must be signed in to change notification settings - Fork 2.2k
lnwire: add lnwire.OpaqueAddr case in WriteElement for channel back-ups #9856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Use existing serialisation helpers for serialising TC Pand Onion addresses in WriteElement.
And then expand the chanbackup unit tests to cover such a case.
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
7886390
to
b67cd82
Compare
Fix a serialisation bug that would occur when an attempt was made to write
a backup file for a channel peer that has advertised an address that we do
not yet know how to parse.
The
WriteElement
method did not have a type for the newlnwire.OpaqueAddr
type.WriteElement
is only used for addresses from withinchanbackup
and so if a node has a channel peer that is advertising an address that we dont know how to parse yet, we would let it be anlnwire.OpaqueAddr
type and this would then error out when we try to make a static chan backup for that peer.