build: quote paths interpolated into the generated shell scripts - #196
Open
findajay wants to merge 1 commit into
Open
build: quote paths interpolated into the generated shell scripts#196findajay wants to merge 1 commit into
findajay wants to merge 1 commit into
Conversation
Three bootstrap steps build a shell command by formatting a path
straight into a redirect target:
b.fmt("echo '{s}' > {s}/.gclient", .{ gclient_content, v8_dir })
Unquoted, the shell splits on whitespace, so a checkout under a path
containing a space -- "/home/user/my projects/zig-v8-fork" -- redirects
to "/home/user/my" and leaves the rest as stray arguments. The bootstrap
then fails with no useful indication of why.
Quote the redirect targets. The same change makes the paths safe on
Windows, where the separator is a backslash and the shell would
otherwise read it as an escape.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016rpebiAtvokoPgpBRVweJo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three bootstrap steps build a shell command by formatting a path straight into a redirect target:
Unquoted, the shell splits on whitespace, so a checkout under a path containing a space -- "/home/user/my projects/zig-v8-fork" -- redirects to "/home/user/my" and leaves the rest as stray arguments. The bootstrap then fails with no useful indication of why.
Quote the redirect targets. The same change makes the paths safe on Windows, where the separator is a backslash and the shell would otherwise read it as an escape.