-
Notifications
You must be signed in to change notification settings - Fork 105
feat(multimodal): configurable tensor transport + vLLM SHM and video #1818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -664,6 +664,18 @@ pub struct WorkerSpec { | |
| /// Falls back to the global `load_monitor_interval_secs` from router config. | ||
| #[serde(default, skip_serializing_if = "Option::is_none")] | ||
| pub load_monitor_interval_secs: Option<u64>, | ||
|
|
||
| /// Per-worker multimodal tensor transport override (`inline` | `shm` | `auto`). | ||
| /// When set, overrides the router-level `multimodal_tensor_transport` default | ||
| /// for this worker (e.g. force `shm` for a co-located worker, `inline` for a | ||
| /// remote one). | ||
| #[serde(default, skip_serializing_if = "Option::is_none")] | ||
| pub multimodal_tensor_transport: Option<String>, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Nit: This field accepts any string without validation. A typo like |
||
|
|
||
| /// Per-worker minimum multimodal tensor size (bytes) before the SHM transport | ||
| /// is used. When set, overrides the router-level `multimodal_shm_min_bytes`. | ||
| #[serde(default, skip_serializing_if = "Option::is_none")] | ||
| pub multimodal_shm_min_bytes: Option<usize>, | ||
| } | ||
|
|
||
| impl WorkerSpec { | ||
|
|
@@ -694,6 +706,8 @@ impl WorkerSpec { | |
| resilience: ResilienceUpdate::default(), | ||
| max_connection_attempts: default_max_connection_attempts(), | ||
| load_monitor_interval_secs: None, | ||
| multimodal_tensor_transport: None, | ||
| multimodal_shm_min_bytes: None, | ||
| } | ||
| } | ||
| } | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.