Move .INI settings to Project Settings and replace autoloads with dependency injection#5
Open
bion33 wants to merge 2 commits into
Open
Move .INI settings to Project Settings and replace autoloads with dependency injection#5bion33 wants to merge 2 commits into
bion33 wants to merge 2 commits into
Conversation
- Move settings from separate .INI to project settings - Replace autoloaded TTS instance with dependency injection - Make loggin configurable Inspiration for how to do project settings: WAT-Sharp
Author
|
Oh, almost forgot to mention, I tested this on Godot 3.3 |
Contributor
|
Thanks! I'll check this out in the next day or two.
One question though. Part of why I went with the separate file approach
was to separate enabling of editor accessibility from the project file,
which is a part of the game. My goal was to enable collaboration without
forcing everyone to use the screen reader in the editor, and to avoid
accidentally committing and recommitting settings changes. Does this PR
achieve that somehow?
Thanks again, I do appreciate it!
|
Author
|
I didn't think of that, this PR indeed does not achieve that at the moment. I've just tested moving the settings to the Editor Settings, and that works with minor changes. Would that be a good solution to the problem or does it have drawbacks of its own? |
- Make logging an exported property of ScreenReader - Move should_stop_on_focus back to ScreenReader, where it was originally - Initialise TTS in ScreenReader instead of Plugin, so that it works in games too (that wasn't particularly smart of me) - Prevent connect() errors when ScreenReader._enter_tree() is called more than once (for example when moving the node in the tree).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge request:
The settings are:
I got the inspiration for how to make the settings available in project settings from WAT-Sharp.
These were just changes which were convenient for me personally, so let me know if I should change anything :)