Skip to content

fix: custom metrics ref link in main readme#263

Merged
asamal4 merged 1 commit into
lightspeed-core:mainfrom
asamal4:fix-metric-ref-link
Jun 26, 2026
Merged

fix: custom metrics ref link in main readme#263
asamal4 merged 1 commit into
lightspeed-core:mainfrom
asamal4:fix-metric-ref-link

Conversation

@asamal4

@asamal4 asamal4 commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Description

fix: custom metrics ref link in main readme

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Unit tests improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
  • Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • Documentation
    • Updated the README links for several custom turn-level metrics to point to their current locations.
    • Improved navigation for answer_correctness, intent_eval, tool_eval, and keywords_eval references.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: dcdff96c-d305-4861-98a5-7bebe621e500

📥 Commits

Reviewing files that changed from the base of the PR and between 27b4aa2 and 0b9fb21.

📒 Files selected for processing (1)
  • README.md

Walkthrough

The README’s Turn-Level (Single Query) custom metric links were updated to point to newer module paths under src/lightspeed_evaluation/core/metrics/custom/.

Changes

README metric links

Layer / File(s) Summary
Updated metric links
README.md
The Turn-Level (Single Query) custom metric bullets now reference the new custom/ module locations for answer_correctness, intent_eval, tool_eval, and keywords_eval.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the README documentation fix for custom metrics reference links.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@asamal4 asamal4 merged commit a0e5c66 into lightspeed-core:main Jun 26, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant