Update - #2
Conversation
|
@copilot pls do review |
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Vim configuration, primarily adjusting editor defaults and updating plugin setup.
Changes:
- Set global indentation defaults (4-space, expand tabs) and enable syntax highlighting.
- Update YouCompleteMe plugin source and add additional YCM key mappings.
- Add visible whitespace rendering (
list/listchars) and introduce Copilot-related config placeholders.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Plugin 'valloric/youcompleteme' | ||
| Plugin 'ycm-core/YouCompleteMe' | ||
| Plugin 'vhda/verilog_systemverilog.vim' | ||
| "" Plugin 'github/copilot.vim' |
There was a problem hiding this comment.
Line is commented with two quote characters ("" Plugin ...). Vim treats " as the comment leader, so the extra quote is just noise and makes it look like an accidental typo. Use a single leading " (or remove the line entirely) to keep the config unambiguous.
| "" Plugin 'github/copilot.vim' | |
| " Plugin 'github/copilot.vim' |
| Plugin 'vhda/verilog_systemverilog.vim' | ||
| "" Plugin 'github/copilot.vim' | ||
| call vundle#end() " required | ||
| let &rtp .= ',' . expand( '<sfile>:p:h' ) |
There was a problem hiding this comment.
let &rtp .= ',' . expand('<sfile>:p:h') appends the directory containing this vimrc to runtimepath. In this repo that directory doesn’t contain any runtime scripts/plugins, so this is effectively a no-op at best, and at worst can cause Vim to source unintended runtime files if anything is added there later. Consider removing it or pointing runtimepath at a specific, intended runtime directory (e.g., a dedicated vim/ subfolder).
| let &rtp .= ',' . expand( '<sfile>:p:h' ) |
| set list | ||
|
|
||
| set listchars=tab:▸\ ,trail:·,precedes:←,extends:→,nbsp:· | ||
| ",multispace:→\ \ \ |
There was a problem hiding this comment.
The trailing commented fragment ",multispace:... looks like it was meant to be part of the set listchars=... configuration but is currently disabled and left as a dangling line. Either remove it or fold the multispace: setting into the set listchars line so the intended listchars configuration is explicit and maintainable.
| ",multispace:→\ \ \ |
TBD