-
Notifications
You must be signed in to change notification settings - Fork 11
Connected view/src/StoredStateStore.tsx to patchConnection. #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connected view/src/StoredStateStore.tsx to patchConnection. #77
Conversation
|
@gunjanghate I'm running into an issue trying to test these changes. When running the patch with Screen.Recording.2025-10-01.at.4.39.00.PM.mov |
|
Sure, will check this |
|
Can you share logs or console output from Cmajor when the black screen appears? |
…feat/lilyvanoekel#61-sync-stored-state
@gunjanghate unfortunately I've not been able to get any console output or other logs from cmajor. I think the best approach is to take it one step at a time and see where it breaks. Keep in mind you need to build the view with |
@lilyvanoekel The black screen issue is fixed now
|
|
@gunjanghate thank you! I've tested it and it works for me as well. Could you clean up the PR a little? I think you can remove any console logs, maybe error handling could be simplified? |
|
@lilyvanoekel Check now ! |

🎵 Summary of Changes
This PR adds Cmajor stored state synchronization for UI preferences, starting with the selected instrument.
Previously, only parameter values were persisted across plugin sessions in DAWs. With this PR, the selected instrument is now saved and restored automatically, allowing users to continue where they left off. The implementation is future-friendly additional UI state keys can be persisted with minimal effort.
🏷️ Type of Change
💡 Motivation/Reason
Persisting only parameter data caused UI selections (like instrument choice) to reset every time a DAW session was reopened. This was frustrating and inconsistent with user expectations.
By syncing StoredStateStore ↔ PatchConnection stored state, we achieve session continuity, making the user experience more polished and professional.
🧪 Testing Done
npm test)StoredStateStore.test.tsxcovering sync logicsendStoredStateValue🔗 Related Issues
Fixes #61
📝 Additional Notes
PatchConnectionis present (e.g., dev mode / tests)refavoids stale closure bugs in listener callbacks📋 Checklist