-
Notifications
You must be signed in to change notification settings - Fork 11
Implement dsp cmajor code for ride bell #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement dsp cmajor code for ride bell #79
Conversation
|
@RakinduM thanks for this! I had to look up what a ride bell actually sounds like π . I wonder if we might raise the base pitch a bit and thin it out a bit more with the high pass filter? Alternatively, do you want to see if you can make those things configurable with parameters? Every sound has "slots" for up to 3 custom parameters. The kick has one defined for And finally, I was thinking about how/where to include this in the UI. And I was thinking maybe for now we could have a group with a bell emoji (π) above the cow bell group. Do you want to include that in the PR? I could do it after as well, up to you! |
|
@lilyvanoekel I'll give it a try to raise the base pitch and thin out the high pass filter. Yeah that's better to place it in above the cow bell group and I'll add it now. I would like to configure the parameters after this PR. |
|
Ride Bell Inst.mp3 |
|
@RakinduM thanks for making the changes! It's taking me a little longer to get to this, but I hope to have a look at it later today! |
|
@lilyvanoekel No worries, take your time. |
lilyvanoekel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @RakinduM , this is pretty neat! Let me know if you want me to create an issue to parameterize some of the settings such as base pitch and high pass cut off (and maybe another param if you can think of something else!). You can create one yourself too if you want or if you're not interested in this I can take a look at that myself after hacktoberfest is over!
|
No worries @lilyvanoekel, Yeah could u create an issue for that to parametarize base pitch and highpass cut off, then I can work on it. I would like to contribute to this project even after the Hacktoberfest :) |
π΅ Summary of Changes
Implemented the dsp cmajor code for ride bell and added the ride bell sound for testing.
π·οΈ Type of Change
π‘ Motivation/Reason
As a developer with a passion for music, I find this project is really interesting. Instead of Tweaking knobs, hitting keys n pads and messing with Ableton, this time I wanted to create a realistic bell sound in the code. Not an expert of sound designing, but I gave it a shot.
π§ͺ Testing Done
npm run build)Cmajor: Run patchcommandπ Related Issues
Fixes #35
π Checklist