Skip to content

Conversation

@RakinduM
Copy link
Contributor

@RakinduM RakinduM commented Oct 6, 2025

🎡 Summary of Changes

Implemented the dsp cmajor code for ride bell and added the ride bell sound for testing.

🏷️ Type of Change

  • πŸ› Bug fix
  • πŸ₯ New drum sound/instrument
  • 🎚️ Improvement to existing sound/instrument
  • ✨ Feature enhancement
  • πŸ“– Documentation update
  • πŸ”§ Code refactoring
  • πŸ§ͺ Test improvements
  • 🎨 UI/View improvements

πŸ’‘ Motivation/Reason

As a developer with a passion for music, I find this project is really interesting. Instead of Tweaking knobs, hitting keys n pads and messing with Ableton, this time I wanted to create a realistic bell sound in the code. Not an expert of sound designing, but I gave it a shot.

πŸ§ͺ Testing Done

  • πŸ—οΈ Built view successfully (npm run build)
  • 🎧 Tested with Cmajor: Run patch command
  • βœ… No breaking changes to existing functionality
  • πŸ”Š Audio output sounds correct (for audio changes)
  • πŸ“± UI works as expected (for view changes)

πŸ”— Related Issues

Fixes #35

πŸ“‹ Checklist

  • πŸ“– I have read the contributing guidelines
  • 🌿 My code follows the project conventions
  • πŸ’¬ I have written clear commit messages
  • 🎯 This PR focuses on a single change

@RakinduM RakinduM changed the title Implement dsp cmajor code for ride bell #35 Implement dsp cmajor code for ride bell Oct 7, 2025
@lilyvanoekel
Copy link
Owner

@RakinduM thanks for this! I had to look up what a ride bell actually sounds like πŸ˜„ .

I wonder if we might raise the base pitch a bit and thin it out a bit more with the high pass filter?

Alternatively, do you want to see if you can make those things configurable with parameters? Every sound has "slots" for up to 3 custom parameters. The kick has one defined for decay although that's not actually currently used when generating its sound.

And finally, I was thinking about how/where to include this in the UI. And I was thinking maybe for now we could have a group with a bell emoji (πŸ””) above the cow bell group. Do you want to include that in the PR? I could do it after as well, up to you!

@RakinduM
Copy link
Contributor Author

RakinduM commented Oct 7, 2025

@lilyvanoekel I'll give it a try to raise the base pitch and thin out the high pass filter. Yeah that's better to place it in above the cow bell group and I'll add it now. I would like to configure the parameters after this PR.

@RakinduM
Copy link
Contributor Author

RakinduM commented Oct 10, 2025

Ride Bell Inst.mp3
Hi @lilyvanoekel, I raised the base pitch, high pass and add to UI under bell(πŸ””) icon. I also add a recording for your reference. Not sure it is clear enough though.

@lilyvanoekel
Copy link
Owner

@RakinduM thanks for making the changes! It's taking me a little longer to get to this, but I hope to have a look at it later today!

@RakinduM
Copy link
Contributor Author

@lilyvanoekel No worries, take your time.

Copy link
Owner

@lilyvanoekel lilyvanoekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @RakinduM , this is pretty neat! Let me know if you want me to create an issue to parameterize some of the settings such as base pitch and high pass cut off (and maybe another param if you can think of something else!). You can create one yourself too if you want or if you're not interested in this I can take a look at that myself after hacktoberfest is over!

@lilyvanoekel lilyvanoekel merged commit 56eda81 into lilyvanoekel:main Oct 11, 2025
1 check passed
@RakinduM
Copy link
Contributor Author

No worries @lilyvanoekel, Yeah could u create an issue for that to parametarize base pitch and highpass cut off, then I can work on it. I would like to contribute to this project even after the Hacktoberfest :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement DSP/Cmajor code for 'Ride Bell' (Midi note 53)

2 participants