-
Notifications
You must be signed in to change notification settings - Fork 11
Add side stick sound (midi note 37) #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add side stick sound (midi note 37) #81
Conversation
|
Hi, so I saw that the side stick file was already existing, but it sounded more like a "pew" than what is in the videos I found (video for example), would this be the sound I'm going for? |
hi @rileychou ! Sorry for the confusion here! The side stick implementation currently in Percupuff is only a placeholder. I used it to document how to add a new sound to the synthesizer, but did not try to model it to sound after anything in particular. The video you linked is probably what we would want the side stick sound in Percupuff to sound like as well. So feel free to use that as a reference! |
view/src/params.ts
Outdated
| kick1: { name: "Acoustic Kick", group: "Kicks", midi: 35 }, | ||
| kick2: { name: "Electric Kick", group: "Kicks", midi: 36 }, | ||
|
|
||
| sideStick: { name: "Side Stick", group: "Snares", midi: 37 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have to be a little bit careful here, adding additional instruments kind of breaks the layout currently. My idea was for these PRs to only focus on adding the sound and parameters needed, and worry about how to add them in the instrument selector later when we have a few more sounds to add.
|
I wonder if we might want this sound to be a bit more "realistic" one thing we could try is to start with the analog snare sound, and see if we can make it sound "lighter" somehow to more resemble the sound from the video. |
Thanks, should I keep a copy of the original side stick if there's a copy in the readme? |
|
@lilyvanoekel I'm running into a problem where for some reason the notch filter isn't getting applied to my I removed it from the top part of the UI btw, now I just access the sound from the keyboard **EDIT: I realized it's because I forgot to update freecompress-Screen.Recording.2025-10-22.at.9.39.20.PM.mp4 |
|
@rileychou sorry for the delay, I'll have a look at this and your other PR over the weekend! |
lilyvanoekel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great, thanks @rileychou !
🎵 Summary of Changes
This PR adds the side stick to the UI and modifies the existing sound to sound more like a side stick hitting the side of the drum.
clickEnvelopeto add more roundness (? im not sure how to describe it) to the sound. The goal was to make it more echoey and less like 2 wooden blocks hitting each other🏷️ Type of Change
💡 Motivation/Reason
After adding the electric snare sound, I wanted to try making a different sound, so I decided to work on the side stick. I also wanted to try adding a sound that isn't on the UI.
🧪 Testing Done
npm run build)Cmajor: Run patchcommand🔗 Related Issues
Fixes #31
📝 Additional Notes
Screen.Recording.2025-10-21.at.9.47.20.PM.mov
📋 Checklist