Skip to content

Conversation

@rileychou
Copy link
Contributor

@rileychou rileychou commented Oct 21, 2025

🎵 Summary of Changes

This PR adds the side stick to the UI and modifies the existing sound to sound more like a side stick hitting the side of the drum.

  • Combines high pass filter and low pass filter because side stick doesn't have that wide of a frequency range
  • Added a second clickEnvelope to add more roundness (? im not sure how to describe it) to the sound. The goal was to make it more echoey and less like 2 wooden blocks hitting each other

🏷️ Type of Change

  • 🐛 Bug fix
  • 🥁 New drum sound/instrument
  • 🎚️ Improvement to existing sound/instrument
  • ✨ Feature enhancement
  • 📖 Documentation update
  • 🔧 Code refactoring
  • 🧪 Test improvements
  • 🎨 UI/View improvements

💡 Motivation/Reason

After adding the electric snare sound, I wanted to try making a different sound, so I decided to work on the side stick. I also wanted to try adding a sound that isn't on the UI.

🧪 Testing Done

  • 🏗️ Built view successfully (npm run build)
  • 🎧 Tested with Cmajor: Run patch command
  • ✅ No breaking changes to existing functionality
  • 🔊 Audio output sounds correct (for audio changes)
  • 📱 UI works as expected (for view changes)

🔗 Related Issues

Fixes #31

📝 Additional Notes

Screen.Recording.2025-10-21.at.9.47.20.PM.mov

📋 Checklist

  • 📖 I have read the contributing guidelines
  • 🌿 My code follows the project conventions
  • 💬 I have written clear commit messages
  • 🎯 This PR focuses on a single change

@rileychou
Copy link
Contributor Author

rileychou commented Oct 21, 2025

Hi, so I saw that the side stick file was already existing, but it sounded more like a "pew" than what is in the videos I found (video for example), would this be the sound I'm going for?

@rileychou rileychou marked this pull request as ready for review October 22, 2025 05:52
@rileychou rileychou changed the title [DRAFT] first draft of side stick Add side stick sound Oct 22, 2025
@rileychou rileychou changed the title Add side stick sound Add side stick sound (midi note 37) Oct 22, 2025
@lilyvanoekel
Copy link
Owner

Hi, so I saw that the side stick file was already existing, but it sounded more like a "pew" than what is in the videos I found (video for example), would this be the sound I'm going for?

hi @rileychou ! Sorry for the confusion here! The side stick implementation currently in Percupuff is only a placeholder. I used it to document how to add a new sound to the synthesizer, but did not try to model it to sound after anything in particular.

The video you linked is probably what we would want the side stick sound in Percupuff to sound like as well. So feel free to use that as a reference!

kick1: { name: "Acoustic Kick", group: "Kicks", midi: 35 },
kick2: { name: "Electric Kick", group: "Kicks", midi: 36 },

sideStick: { name: "Side Stick", group: "Snares", midi: 37 },
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to be a little bit careful here, adding additional instruments kind of breaks the layout currently. My idea was for these PRs to only focus on adding the sound and parameters needed, and worry about how to add them in the instrument selector later when we have a few more sounds to add.

@lilyvanoekel
Copy link
Owner

I wonder if we might want this sound to be a bit more "realistic" one thing we could try is to start with the analog snare sound, and see if we can make it sound "lighter" somehow to more resemble the sound from the video.

@rileychou
Copy link
Contributor Author

Hi, so I saw that the side stick file was already existing, but it sounded more like a "pew" than what is in the videos I found (video for example), would this be the sound I'm going for?

hi @rileychou ! Sorry for the confusion here! The side stick implementation currently in Percupuff is only a placeholder. I used it to document how to add a new sound to the synthesizer, but did not try to model it to sound after anything in particular.

The video you linked is probably what we would want the side stick sound in Percupuff to sound like as well. So feel free to use that as a reference!

Thanks, should I keep a copy of the original side stick if there's a copy in the readme?

@rileychou
Copy link
Contributor Author

rileychou commented Oct 23, 2025

@lilyvanoekel I'm running into a problem where for some reason the notch filter isn't getting applied to my SideStick.cmajor file, even though the code is identical to the snare code i modified (as shown in the screen recording). The only differences are the input params names but those are set to the same numbers in Params.cmajor. As a result, it doesn't have the noise that i achieved when i tried playing around with the snare. Do you know why that might be happening? I pushed my latest code that's having this problem

I removed it from the top part of the UI btw, now I just access the sound from the keyboard

**EDIT: I realized it's because I forgot to update Percupuff.cmajor to connect noise to the side stick. This is no longer happening since I've updated my code.

freecompress-Screen.Recording.2025-10-22.at.9.39.20.PM.mp4

@lilyvanoekel
Copy link
Owner

@rileychou sorry for the delay, I'll have a look at this and your other PR over the weekend!

Copy link
Owner

@lilyvanoekel lilyvanoekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great, thanks @rileychou !

@lilyvanoekel lilyvanoekel merged commit 752a47e into lilyvanoekel:main Oct 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement DSP/Cmajor code for 'Side Stick' (Midi note 37)

2 participants