pkg/networks/usernet: use domain.tld zones#4772
Open
julego wants to merge 1 commit intolima-vm:masterfrom
Open
pkg/networks/usernet: use domain.tld zones#4772julego wants to merge 1 commit intolima-vm:masterfrom
julego wants to merge 1 commit intolima-vm:masterfrom
Conversation
Signed-off-by: Julien Le Goff <julego@gmail.com>
Member
|
CI failing https://github.com/lima-vm/lima/actions/runs/23485110542/job/69213743913?pr=4772 |
Author
|
I just checked the test, it failed because the dns server implemented in gvisor-tap-vsock doesn't seem to handle domain.tld zones so well. With domain.tld zones, sublevel records such as project.dev.tld are well resolved by gvisor-tap-vsock (what I was testing on my dev env) but root records like dev.tld are not (whether the tld is ".internal" or not). Hence the test failing with "lima-net-user-v2-1.internal". I'll have a look at this but gvisor-tap-vsock will probably need a patch too, I don't think there's a direct fix in lima. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The usernet client stores dns records in tld zones, and as such the default host.lima.internal record breaks resolving .internal domains that may exist on the host network (e.g. compute.internal, dev.internal, etc).
This is a proposal to store dns records in domain.tld zones to be able to use such domains.
It may close #3161 also.