Added basic Campaign, Template support plus added some minor improvements #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…justments to pom and the addition of a new method templateAdd with supporting serialization classes.
added some test cases
removed unused templateId from createCampaign API
a complete merge_vars.
MailChimp added a new property to their API without incrementing the API version number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I needed to use MailChimp and upload a hundred thousand or so users with a few dozen list variables for segmentation. I found your library and started using it right away. I discovered that there were some features that I needed that your library didn't cover, namely Campaigns and Templates "namespaces".
So, I forked and added those elements. Its not full support for either, MailChimp offers a lot of options that I simply didn't need, but it sets the basics down and its working. Using my fork, you can list campaigns, pull unsubscribes, bounces, etc. You can create new campaigns and attach templates etc. All of that doesn't conflict with your work, and I have tried to follow your style as much as possible.
Second important change does touch your work. listBatchSubscribe only supported email out of the box. I needed to support my entire list of variables. So I created WithVars variants which allow you to provide the same Map for listBatchSubscribe as you could in updateMember. Its actually undocumented by MailChimp, but it works.
Please let me know if you have any questions. I might have another minor pull in a few months, but I wanted to get this up before I moved projects again.
This is my first pull request, so I am not sure what this looks like through the process, hopefully I don't create too much work. You will want to ignore the POM since I changed the name of your project, I will try to exclude it in the request.
Tim