feat(cozy-ui-plus): Create own FlagImage to show country flags#2934
Merged
feat(cozy-ui-plus): Create own FlagImage to show country flags#2934
Conversation
BREAKING CHANGE: You must have `cozy-client >= 60.21.3`
based on emojis and not on external lib anymore because the stack won't allow to load external codes from cdn
rezk2ll
reviewed
Feb 23, 2026
| fireEvent.click(actionButton) | ||
| expect(openSpy).toBeCalledWith( | ||
| 'http://mycozy.cloud/cozy/instances/123/premium', | ||
| 'http://mycozy.cloud/cozy/instances/123/premium?lang=en', |
Contributor
Author
There was a problem hiding this comment.
because of upgrading cozy-client. Something has changed there, it's a side effect
Member
There was a problem hiding this comment.
With recent cozy-client version, we pass the lang when we can to "select" the language of the cloudery. It seems we put a default value to "en".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on emojis and not on external lib anymore because the stack won't allow to load external codes from cdn