Skip to content

fix: Move client creation modal in parent#795

Open
KillianCourvoisier wants to merge 1 commit intomasterfrom
fix/createClientOnEmptyList
Open

fix: Move client creation modal in parent#795
KillianCourvoisier wants to merge 1 commit intomasterfrom
fix/createClientOnEmptyList

Conversation

@KillianCourvoisier
Copy link
Contributor

@KillianCourvoisier KillianCourvoisier commented Feb 5, 2026

The “Create OAuth client” modal could not be opened when there were no devices, even though the button was visible.
I moved the modal rendering out of the devices table and into the page-level layout so it is available even when the device list is empty.

Summary by CodeRabbit

  • Refactor
    • Improved component structure for better code organization and maintainability.

@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2026

Walkthrough

The DevicesModaleCreateOAuthClient modal's rendering location within the DevicesView component is being repositioned. Previously, the modal was conditionally rendered within the devices table structure. This change moves it to render directly after the PageHeader component. The modal's visibility logic controlled by the isCreateOAuthClientModalOpen state and the onClose callback behavior remain unchanged. This modification affects the component tree structure and DOM hierarchy without altering the functional behavior of the modal's open/close mechanism.

Possibly related PRs

Suggested reviewers

  • doubleface
  • rezk2ll
  • zatteo
  • lethemanh
  • JF-Cozy
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: moving the client creation modal to the parent component level.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/createClientOnEmptyList

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bundlemon
Copy link

bundlemon bot commented Feb 5, 2026

BundleMon

Unchanged files (9)
Status Path Size Limits
static/js/cozy.(hash).js
521.12KB -
static/js/(chunkId).(hash).js
499.5KB -
static/js/main.(hash).js
142.81KB -
static/js/lib-react.(hash).js
43.88KB -
static/css/main.(hash).css
29.88KB -
static/css/cozy.(hash).css
29.44KB -
static/js/lib-router.(hash).js
21.86KB -
static/svg/export-cozy-mail.(hash).svg
700B -
static/svg/import-cozy.(hash).svg
630B -

Total files change +1B 0%

Unchanged groups (3)
Status Path Size Limits
**/*.js
1.86MB -
**/*.{png,svg,ico}
277KB -
**/*.css
79.1KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants