fix: Move client creation modal in parent#795
fix: Move client creation modal in parent#795KillianCourvoisier wants to merge 1 commit intomasterfrom
Conversation
WalkthroughThe DevicesModaleCreateOAuthClient modal's rendering location within the DevicesView component is being repositioned. Previously, the modal was conditionally rendered within the devices table structure. This change moves it to render directly after the PageHeader component. The modal's visibility logic controlled by the isCreateOAuthClientModalOpen state and the onClose callback behavior remain unchanged. This modification affects the component tree structure and DOM hierarchy without altering the functional behavior of the modal's open/close mechanism. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
BundleMonUnchanged files (9)
Total files change +1B 0% Unchanged groups (3)
Final result: ✅ View report in BundleMon website ➡️ |
The “Create OAuth client” modal could not be opened when there were no devices, even though the button was visible.
I moved the modal rendering out of the devices table and into the page-level layout so it is available even when the device list is empty.
Summary by CodeRabbit