feat(catalog-ui): add rename favorite button and dialog#226
Open
jcabannes wants to merge 1 commit into
Open
Conversation
jcabannes
requested review from
Hamilcar31,
Zorin95670,
christophechevalier and
juliajmn
jcabannes
force-pushed
the
feature/rename-favorite-filter
branch
from
efe7a17 to
12e7fc7
Compare
Contributor
NX Running target test:ci for 3 projects:
- module-import
- module-users
- catalog-ui
::group::✅ > nx run module-users:"test:ci"
> vitest run --coverage --reporter=dot --passWithNoTests
The plugin "vite-tsconfig-paths" is detected. Vite now supports tsconfig paths resolution natively via the resolve.tsconfigPaths option. You can remove the plugin and set resolve.tsconfigPaths: true in your Vite config instead.
RUN v4.1.10 /home/runner/work/linid-im-front-community-plugins/linid-im-front-community-plugins/apps/module-users
Coverage enabled with v8
·····································································
Test Files 5 passed (5)
Tests 69 passed (69)
Start at 16:32:33
Duration 6.30s (transform 1.24s, setup 0ms, import 4.36s, tests 1.31s, environment 6.14s)
% Coverage report from v8
-------------------|---------|----------|---------|---------|-------------------
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
-------------------|---------|----------|---------|---------|-------------------
All files | 100 | 100 | 100 | 100 |
src | 100 | 100 | 100 | 100 |
...-lifecycle.ts | 100 | 100 | 100 | 100 |
routes.ts | 0 | 0 | 0 | 0 |
src/i18n | 0 | 0 | 0 | 0 |
index.ts | 0 | 0 | 0 | 0 |
src/i18n/en-US | 0 | 0 | 0 | 0 |
index.ts | 0 | 0 | 0 | 0 |
src/i18n/fr-FR | 0 | 0 | 0 | 0 |
index.ts | 0 | 0 | 0 | 0 |
src/pages | 100 | 100 | 100 | 100 |
EditUserPage.vue | 100 | 100 | 100 | 100 |
HomePage.vue | 100 | 100 | 100 | 100 |
NewUserPage.vue | 100 | 100 | 100 | 100 |
...tailsPage.vue | 100 | 100 | 100 | 100 |
src/types | 0 | 0 | 0 | 0 |
moduleUsers.ts | 0 | 0 | 0 | 0 |
-------------------|---------|----------|---------|---------|-------------------
::endgroup::
::group::✅ > nx run module-import:"test:ci"
> vitest run --coverage --reporter=dot --passWithNoTests
The plugin "vite-tsconfig-paths" is detected. Vite now supports tsconfig paths resolution natively via the resolve.tsconfigPaths option. You can remove the plugin and set resolve.tsconfigPaths: true in your Vite config instead.
RUN v4.1.10 /home/runner/work/linid-im-front-community-plugins/linid-im-front-community-plugins/apps/module-import
Coverage enabled with v8
··························stderr | tests/unit/components/button/ImportButton.spec.js > Test component: ImportButton > Test function: goToImport > should navigate to module basePath on click
[Vue warn]: Missing required prop: "uiNamespace"
at <ImportButton instanceId="test-instance" ref="VTU_COMPONENT" >
at <VTUROOT>
·
Test Files 4 passed (4)
Tests 27 passed (27)
Start at 16:32:33
Duration 6.74s (transform 1.91s, setup 0ms, import 5.98s, tests 621ms, environment 4.88s)
% Coverage report from v8
-------------------|---------|----------|---------|---------|-------------------
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
-------------------|---------|----------|---------|---------|-------------------
All files | 91.33 | 76.92 | 87.75 | 91.45 |
src | 0 | 100 | 0 | 0 |
...-lifecycle.ts | 0 | 100 | 0 | 0 | 55-83
routes.ts | 0 | 0 | 0 | 0 |
...ponents/button | 100 | 100 | 100 | 100 |
ImportButton.vue | 100 | 100 | 100 | 100 |
...mponents/field | 90.19 | 66.66 | 90.47 | 90 |
...ilesField.vue | 90.19 | 66.66 | 90.47 | 90 | 88-89,121,165,212
...mponents/table | 100 | 100 | 100 | 100 |
...DataTable.vue | 100 | 100 | 100 | 100 |
src/i18n | 0 | 0 | 0 | 0 |
index.ts | 0 | 0 | 0 | 0 |
src/i18n/en-US | 0 | 0 | 0 | 0 |
index.ts | 0 | 0 | 0 | 0 |
src/i18n/fr-FR | 0 | 0 | 0 | 0 |
index.ts | 0 | 0 | 0 | 0 |
src/pages | 98.03 | 100 | 95 | 100 |
ImportPage.vue | 98.03 | 100 | 95 | 100 |
src/types | 0 | 0 | 0 | 0 |
File.ts | 0 | 0 | 0 | 0 |
ImportButton.ts | 0 | 0 | 0 | 0 |
...dDataTable.ts | 0 | 0 | 0 | 0 |
LoadFileCard.ts | 0 | 0 | 0 | 0 |
common.ts | 0 | 0 | 0 | 0 |
moduleImport.ts | 0 | 0 | 0 | 0 |
papaparse.d.ts | 0 | 0 | 0 | 0 |
-------------------|---------|----------|---------|---------|-------------------
::endgroup::
::group::✅ > nx run catalog-ui:"test:ci"
> vitest run --coverage --reporter=dot --passWithNoTests
The plugin "vite-tsconfig-paths" is detected. Vite now supports tsconfig paths resolution natively via the resolve.tsconfigPaths option. You can remove the plugin and set resolve.tsconfigPaths: true in your Vite config instead.
RUN v4.1.10 /home/runner/work/linid-im-front-community-plugins/linid-im-front-community-plugins/apps/catalog-ui
Coverage enabled with v8
·····························································································································································································································································································································································································································································
Test Files 29 passed (29)
Tests 445 passed (445)
Start at 16:32:33
Duration 18.00s (transform 4.54s, setup 0ms, import 17.51s, tests 4.67s, environment 19.09s)
% Coverage report from v8
-------------------|---------|----------|---------|---------|-------------------
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
-------------------|---------|----------|---------|---------|-------------------
All files | 89.16 | 90.16 | 81.53 | 89.15 |
components/button | 100 | 100 | 100 | 100 |
...ownButton.vue | 100 | 100 | 100 | 100 |
components/card | 91.83 | 100 | 100 | 91.48 |
...earchCard.vue | 100 | 100 | 100 | 100 |
ButtonsCard.vue | 100 | 100 | 100 | 100 |
...tailsCard.vue | 100 | 100 | 100 | 100 |
...ationCard.vue | 0 | 100 | 100 | 0 | 76-84
components/chip | 9.09 | 0 | 0 | 9.09 |
...ilterChip.vue | 9.09 | 0 | 0 | 9.09 | 28-39,68-78
components/dialog | 96.49 | 90 | 84.61 | 100 |
...ionDialog.vue | 95.23 | 83.33 | 83.33 | 100 | 127
FormDialog.vue | 97.22 | 92.85 | 85.71 | 100 | 181
components/field | 97.14 | 95.68 | 91.25 | 97.04 |
...leanField.vue | 100 | 75 | 100 | 100 | 61
...DateField.vue | 100 | 97.05 | 100 | 100 | 131
...ListField.vue | 100 | 96.96 | 100 | 100 | 210
...mailField.vue | 100 | 87.5 | 100 | 100 | 72
...buteField.vue | 50 | 100 | 30 | 50 | 59-62,65-73
...ListField.vue | 100 | 100 | 100 | 100 |
...mberField.vue | 100 | 87.5 | 100 | 100 | 71
...AreaField.vue | 100 | 87.5 | 100 | 100 | 71
...TextField.vue | 100 | 100 | 100 | 100 |
components/loader | 100 | 100 | 100 | 100 |
BlurLoader.vue | 100 | 100 | 100 | 100 |
components/menu | 100 | 100 | 100 | 100 |
...ationMenu.vue | 100 | 100 | 100 | 100 |
...onents/profile | 100 | 100 | 100 | 100 |
...erProfile.vue | 100 | 100 | 100 | 100 |
...s/smart-filter | 93.65 | 95.89 | 92.59 | 93.78 |
...lterPanel.vue | 100 | 100 | 100 | 100 |
...ritePanel.vue | 0 | 100 | 0 | 0 | 147-159
...lterPanel.vue | 100 | 100 | 100 | 100 |
...artFilter.vue | 100 | 90 | 100 | 100 | 215
...lterPanel.vue | 100 | 100 | 100 | 100 |
...lterPanel.vue | 85 | 100 | 57.14 | 84.21 | 33-53
...lterPanel.vue | 100 | 100 | 100 | 100 |
...lterPanel.vue | 98.07 | 92.85 | 100 | 98.07 | 131
components/table | 0 | 100 | 0 | 0 |
...tityTable.vue | 0 | 100 | 0 | 0 | 28-75
components/tree | 82.19 | 63.88 | 51.72 | 80.88 |
GenericTree.vue | 82.19 | 63.88 | 51.72 | 80.88 | 31-111
federation | 88.88 | 100 | 66.66 | 88.88 |
empty-i18n.ts | 0 | 0 | 0 | 0 |
...-lifecycle.ts | 0 | 100 | 0 | 0 | 46
empty-route.ts | 0 | 0 | 0 | 0 |
...-lifecycle.ts | 100 | 100 | 100 | 100 |
...page-route.ts | 0 | 0 | 0 | 0 |
layouts | 0 | 100 | 0 | 0 |
BaseLayout.vue | 0 | 100 | 0 | 0 | 110-133
pages | 74.19 | 90.47 | 70.73 | 73.49 |
...TablePage.vue | 74.19 | 90.47 | 70.73 | 73.49 | 281-306,377-488
services | 100 | 100 | 100 | 100 |
...istService.ts | 100 | 100 | 100 | 100 |
types | 100 | 100 | 100 | 100 |
...mationCard.ts | 0 | 0 | 0 | 0 |
...ilterPanel.ts | 0 | 0 | 0 | 0 |
...ageOptions.ts | 0 | 0 | 0 | 0 |
...ageOptions.ts | 0 | 0 | 0 | 0 |
...ilterPanel.ts | 0 | 0 | 0 | 0 |
...SearchCard.ts | 0 | 0 | 0 | 0 |
buttonsCard.ts | 0 | 0 | 0 | 0 |
common.ts | 0 | 0 | 0 | 0 |
...ilterPanel.ts | 0 | 0 | 0 | 0 |
dialog.ts | 100 | 100 | 100 | 100 |
...downButton.ts | 0 | 0 | 0 | 0 |
...etailsCard.ts | 0 | 0 | 0 | 0 |
field.ts | 0 | 0 | 0 | 0 |
...ntityTable.ts | 0 | 0 | 0 | 0 |
genericTree.ts | 0 | 0 | 0 | 0 |
...oritePanel.ts | 0 | 0 | 0 | 0 |
...FilterChip.ts | 0 | 0 | 0 | 0 |
...ilterPanel.ts | 0 | 0 | 0 | 0 |
...gationMenu.ts | 0 | 0 | 0 | 0 |
...ilterPanel.ts | 0 | 0 | 0 | 0 |
smartFilter.ts | 0 | 0 | 0 | 0 |
...ilterPanel.ts | 0 | 0 | 0 | 0 |
-------------------|---------|----------|---------|---------|-------------------
::endgroup::
NX Successfully ran target test:ci for 3 projects
|
Contributor
|
📦 Dependencies Report 🔍 ./apps/module-importUsing pnpm quasar 2.21.1 → 2.21.2 Run npx npm-check-updates -u to upgrade package.json 🔍 ./apps/module-usersUsing pnpm quasar 2.21.1 → 2.21.2 Run npx npm-check-updates -u to upgrade package.json 🔍 ./apps/catalog-uiUsing pnpm quasar 2.21.1 → 2.21.2 Run npx npm-check-updates -u to upgrade package.json 🔍 .Using pnpm @module-federation/vite 1.16.13 → 1.16.15 Run npx npm-check-updates -u to upgrade package.json 🔍 ./tools/moduleUsing pnpm @nx/devkit 22.2.1 → 23.0.1 Run npx npm-check-updates -u to upgrade package.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.