fixed a huge issue with cleaning inner whitelisted tags (which should…#4
Open
jizuscreed wants to merge 1 commit intolincanbin:masterfrom
Open
fixed a huge issue with cleaning inner whitelisted tags (which should…#4jizuscreed wants to merge 1 commit intolincanbin:masterfrom
jizuscreed wants to merge 1 commit intolincanbin:masterfrom
Conversation
…n't be happened) (cherry picked from commit efa55e2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, there is fix for big issue with deleting whitelisted tags in blacklisted tag. For example:
If we have a code like
and only tag
<a>in white list rules, functionclean()will delete all tags (because<a>tag is in<p>tag) and will return onlytest. It happens because you used $elem->textContent, which returns only text content of element, without tags.With my fix it wil work correct and function will return
<a>test</a>