You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently it looks like the default Zarr version is 3 but the default OME version is 0.4. Changing this default uncovered some issues with linc-convert (e.g. golden test data) and nifti-zarr-py.
Changes
Update the default OME version to 0.5 and require it for Zarr v3
Pass ome_version to write_ome_metadata across all modalities
Derive ome_version from zarr_version in tests and regenerate golden test data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Currently it looks like the default Zarr version is 3 but the default OME version is 0.4. Changing this default uncovered some issues with
linc-convert(e.g. golden test data) andnifti-zarr-py.Changes
ome_versiontowrite_ome_metadataacross all modalitiesome_versionfromzarr_versionin tests and regenerate golden test datacc @satra @ayendiki