Repository navigation
Conversation
The Lombok versions used outside libs/ (1.18.20, 1.18.28, and the one managed by Spring Boot 2.7) do not support JDK 21. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Byte Buddy 1.12 managed by Spring Boot 2.7 cannot mock on Java 21. Test scope only; can be dropped once the starter moves to Spring Boot 3.5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
assertThat(first).isEqualTo(first) always passes because AssertJ short-circuits on reference equality, so it never exercised equals(). Flagged by Error Prone SelfAssertion. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- CI builds with JDK 21 and also installs JDK 8 for the test toolchain. - Compile every module with --release 8, so JDK 8 API usage is checked, not just the bytecode level. The java extension still declares Java 8, so published Gradle module metadata keeps org.gradle.jvm.version=8. - Run libs/ tests on a JDK 8 toolchain so Java 8 runtime behavior stays covered. The foojay resolver provisions JDK 8 locally when it is missing. - Upgrade the Error Prone Gradle plugin to 5.1.1 and Error Prone to 2.50.0; errorproneJavac is no longer needed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches the build and CI from JDK 8 to JDK 21. Published artifacts still target Java 8. This prepares for moving the Spring Boot starters to Spring Boot 3.5 / Java 17, which cannot be built on JDK 8.
--release 8, which also catches JDK 8 API misuse (not only the bytecode level). Thejavaextension still declares Java 8, so the published Gradle module metadata keepsorg.gradle.jvm.version=8.libs/tests run on a JDK 8 toolchain. CI installs JDK 8 next to JDK 21; locally, the foojay resolver downloads JDK 8 when it is missing.errorproneJavacis no longer needed.libs/do not support JDK 21.isEqualTo(first)assertion flagged by Error ProneSelfAssertion(AssertJ short-circuits on reference equality, soequals()was never called).🤖 Generated with Claude Code