Skip to content

Added a functional interface EventLoopSchedulerFactory #5323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LaylaSilbernberg wants to merge 4 commits into
base: main
Choose a base branch
from
+608 −554
Open

Added a functional interface EventLoopSchedulerFactory #5323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81af7b9
Added a functional interface EventLoopSchedulerFactory
LaylaSilbernberg Dec 4, 2023
f1ff6c6
added new event loop scheduler factory api, deprecated old api, clean…
LaylaSilbernberg Jan 18, 2024
af2f9d0
further cleanup
LaylaSilbernberg Jan 18, 2024
4776e64
Merge branch 'event-loop-scheduler-factory-cleanup' into event-loop-s…
LaylaSilbernberg Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions core/src/main/java/com/linecorp/armeria/client/ClientFactoryBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,10 @@ public ClientFactoryBuilder workerGroup(int numThreads) {
/**
* Sets the factory that creates an {@link EventLoopScheduler} which is responsible for assigning an
* {@link EventLoop} to handle a connection to the specified {@link Endpoint}.
* @deprecated This factory method lacks the ability to build a sophisticated scheduler.
* Use the method that requires an EventLoopSchedulerFactory instead.
*/
@Deprecated
public ClientFactoryBuilder eventLoopSchedulerFactory(
Function<? super EventLoopGroup, ? extends EventLoopScheduler> eventLoopSchedulerFactory) {
requireNonNull(eventLoopSchedulerFactory, "eventLoopSchedulerFactory");
Expand All @@ -169,6 +172,19 @@ public ClientFactoryBuilder eventLoopSchedulerFactory(
return this;
}

/**
* Sets the factory that creates an {@link EventLoopScheduler} which is responsible for assigning an
* {@link EventLoop} to handle a connection to the specified {@link Endpoint}.
* @deprecated This factory method lacks the ability to build a sophisticated scheduler.
* Use the method that requires an EventLoopSchedulerFactory instead.
*/
@Deprecated
public ClientFactoryBuilder eventLoopSchedulerFactory(EventLoopSchedulerFactory eventLoopSchedulerFactory){
requireNonNull(eventLoopSchedulerFactory, "eventLoopSchedulerFactory");
option(ClientFactoryOptions.CUSTOM_EVENT_LOOP_SCHEDULER_FACTORY, eventLoopSchedulerFactory);
return this;
}

/**
* Sets the maximum number of {@link EventLoop}s which will be used to handle HTTP/1.1 connections
* except the ones specified by {@link #maxNumEventLoopsFunction(ToIntFunction)}.
Expand Down
Loading