Refactor HaProxy exception handling - #5805
Merged
Merged
Conversation
trustin
approved these changes
Jul 9, 2024
trustin
left a comment
Contributor
There was a problem hiding this comment.
The simplification looks fine to me. I don't remember anymore why it is written that way anymore to be honest 😅
Contributor
jrhee17
marked this pull request as ready for review
July 9, 2024 23:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
While working on #5793, I found that there were unnecessary
ProxyConnectExceptionrelated handling in the request handler. This is most likely due to the fact thatHaProxyHandlerworks differently from the other proxy handlers in that the session is completed, and then a connection event is published.This was probably when I was less familiar with netty. I propose that the
HaProxyHandlercomplete the session similarly to the other handlers. A connection attempt is made first, and then thesessionPromiseis succeeded or failed accordingly.Modifications:
HaProxyHandlerdoesn't succeed thesessionPromiseimmediately, but waits for the result of theconnectfuture.ProxyConnectExceptionrelated logic in all places except forHttpSessionHandler#exceptionCaughtResult:
AbstractHttpRequestHandlerandHttpSessionHandleris a little simpler.