Skip to content

Fix documentation for client-thrift and client-retry - #6195

Merged
trustin merged 1 commit into
line:mainfrom
pppurple:fix-documents
Apr 9, 2025
Merged

Fix documentation for client-thrift and client-retry#6195
trustin merged 1 commit into
line:mainfrom
pppurple:fix-documents

Conversation

@pppurple

@pppurple pppurple commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

Motivation:

I found an incorrect class name and the use of deprecated functions in the document.
Therefore I fixed it to use the recommended function instead.

Modifications:

  • Change ThriftClient to ThriftClients
  • Use RetryConfig instead of deprecated functions.

Result:

  • The corrected document will be displayed.

@CLAassistant

CLAassistant commented Apr 8, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

`maxTotalAttempts` when you build a <type://RetryingClient>:

```java
RetryingClient.newDecorator(rule, maxTotalAttempts);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


```java
RetryingClient.newDecorator(rule, maxTotalAttempts,
responseTimeoutMillisForEachAttempt);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikhoon ikhoon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pppurple!

@ikhoon ikhoon added the cleanup label Apr 8, 2025
@ikhoon ikhoon added this to the 1.33.0 milestone Apr 8, 2025

@trustin trustin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fixes, @pppurple! 🙏

@minwoox minwoox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trustin
trustin merged commit 4c2c257 into line:main Apr 9, 2025
@trustin trustin changed the title fix documents for client-thrift and client-entry Fix documentation for client-thrift and client-retry Apr 9, 2025
@pppurple
pppurple deleted the fix-documents branch April 9, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants