Skip to content

Watch a Kubernetes service from the latest resource version. #6305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ikhoon merged 1 commit into from
Jul 7, 2025
Merged

Watch a Kubernetes service from the latest resource version. #6305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ...c/main/java/com/linecorp/armeria/client/kubernetes/endpoints/KubernetesEndpointGroup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,11 +422,16 @@ public void onClose() {

final Service service = this.service;
assert service != null;

// Fabric8 Kubernetes client uses a list API to establish a watch connection, such as
// "/api/v1/namespaces/<namespace>/services?fieldSelector=metadata.name=<service-name>&watch=true".
// Therefore, the resource version of a service cannot be used. Instead, it fetches the latest version
// and compares it with the cached version in `watcher.eventReceived()` to decide whether an update is
// needed.
if (namespace == null) {
return client.services().withName(serviceName).withResourceVersion(resourceVersion).watch(watcher);
return client.services().withName(serviceName).watch(watcher);
} else {
return client.services().inNamespace(namespace).withName(serviceName)
.withResourceVersion(resourceVersion).watch(watcher);
return client.services().inNamespace(namespace).withName(serviceName).watch(watcher);
}
}

Expand Down
Loading