Introduce DefaultXdsLoadBalancerLifecycleObserver
#6490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ikhoon
approved these changes
Nov 13, 2025
Comment on lines
+106
to
+107
| final ImmutableList.Builder<Meter> metersBuilder = ImmutableList.builder(); | ||
| metersBuilder.add(Gauge.builder(prefix.name("lb.state.subsets"), () -> numSubsets) |
Contributor
There was a problem hiding this comment.
nit: Collection seems unnecessary.
| localClusterName = bootstrap.getClusterManager().getLocalClusterName(); | ||
| if (!Strings.isNullOrEmpty(localClusterName) && bootstrap.getNode().hasLocality()) { | ||
| final DefaultXdsLoadBalancerLifecycleObserver observer = | ||
| new DefaultXdsLoadBalancerLifecycleObserver(meterIdPrefix, meterRegistry, localClusterName); |
Contributor
There was a problem hiding this comment.
I understand that there’s still no extension point for users to configure a custom XdsLoadBalancerLifecycleObserver.
minwoox
approved these changes
Nov 18, 2025
| private final MeterIdPrefix prefix; | ||
| private final List<Meter> meters; | ||
|
|
||
| private int numSubsets; |
Contributor
There was a problem hiding this comment.
Shouldn't it be volatile or AtomicInteger?
Comment on lines
+156
to
+159
| private int healthyLoad; | ||
| private int degradedLoad; | ||
| private boolean panicState; | ||
| private double zarLocalPercentage; |
Comment on lines
+227
to
+231
| private int total; | ||
| private int healthy; | ||
| private int degraded; | ||
| private int localityWeight; | ||
| private double zarPercentage; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When using xDS based clients, users will often want to know how the xDS resources translate to the load balancer which routes requests upstream.
This changeset attempts introduce a
DefaultXdsLoadBalancerLifecycleObserverwhich collects metrics of each load balancer for each cluster.This observer has the same lifecycle as a
ClusterResourceNode, and will deregister each metric upon close.Note that thanks to
XdsClusterManager, each cluster has a unique name.Modifications:
DefaultXdsLoadBalancerLifecycleObserveris introduced which records metrics for aXdsLoadBalancerMeterRegistry,MeterIdPrefixcan now be specified inXdsBootstrapBuilderMeterRegistry,MeterIdPrefixis also added toSubscriptionContextso that they can be accessed when dynamically querying xDS resourcesEventExecutoris used for the default event loop.Result:
DefaultXdsLoadBalancerLifecycleObservernow records metrics forXdsLoadBalancers by default