Generate the Athenz xDS protos with java_multiple_files - #6915
Conversation
Motivation: The Armeria xDS protos we author follow the java_multiple_files convention (as do the gRPC, example and benchmark modules), but the Athenz protos added in line#6853 were missing it, so their messages were generated as nested classes under an outer wrapper. Modifications: - Add `option java_multiple_files = true;` to armeria/xds/athenz/athenz_filter_config.proto and armeria/xds/athenz/athenz_access_token.proto, so each message is generated as a top-level class. Result: - Athenz xDS message classes are now top-level, matching the convention.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe protobuf definitions enable separate Java files for Athenz declarations. A comment documents the intentional nested ChangesAthenz protobuf type generation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Tick the box to add this pull request to the merge queue (same as
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6915 +/- ##
============================================
+ Coverage 74.46% 75.16% +0.70%
- Complexity 22234 25508 +3274
============================================
Files 1963 2267 +304
Lines 82437 94558 +12121
Branches 10764 12377 +1613
============================================
+ Hits 61385 71078 +9693
- Misses 15918 17601 +1683
- Partials 5134 5879 +745 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Motivation:
The Armeria xDS protos follow the java_multiple_files convention (as do the gRPC, example and benchmark modules), but the Athenz protos added in #6853 were missing it, so their messages were generated as nested classes under an outer wrapper.
Modifications:
option java_multiple_files = true;to armeria/xds/athenz/athenz_filter_config.proto and armeria/xds/athenz/athenz_access_token.proto, so each message is generated as a top-level class.Result: