Serve xDS resources that embed Armeria custom filter configs - #1354
Draft
minwoox wants to merge 1 commit into
Draft
Serve xDS resources that embed Armeria custom filter configs#1354minwoox wants to merge 1 commit into
minwoox wants to merge 1 commit into
Conversation
…henz) Motivation: The xDS control plane parses every stored Listener/Cluster/Route/Endpoint into a proto with a curioswitch MessageMarshaller, which must resolve every google.protobuf.Any it contains (such as an HttpFilter typed_config). The marshaller only registered types under io.envoyproxy.envoy (from java-control-plane) plus a couple of Central Dogma-specific ones. Armeria's xDS filters (e.g. the Athenz access-token filters) are carried as typed_config Any values whose types live in com.linecorp.armeria.xds.athenz and jp.co.lycorp.ftd.athenz.v1, packaged in armeria-xds-api, which Central Dogma did not depend on. Modifications: - Make armeria-xds-api the single provider of io.envoyproxy.envoy types in the :xds module. Result: - xDS resources that embed Armeria custom filter configs, such as the Athenz access-token filters, can now be created, stored and served by the control plane.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe Armeria dependency advances to 1.41.0. The xDS module adds Armeria protobuf types, generalizes protobuf scanning, and adds Athenz typed-configuration parsing and LDS integration tests. ChangesxDS Athenz support
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The xDS control plane parses every stored Listener/Cluster/Route/Endpoint into a proto with a curioswitch MessageMarshaller, which must resolve every google.protobuf.Any it contains (such as an HttpFilter typed_config). The marshaller only registered types under io.envoyproxy.envoy (from java-control-plane) plus a couple of Central Dogma-specific ones. Armeria's xDS filters (e.g. the Athenz access-token filters) are carried as typed_config Any values whose types live in com.linecorp.armeria.xds.athenz and jp.co.lycorp.ftd.athenz.v1, packaged in armeria-xds-api, which Central Dogma did not depend on.
Modifications:
Result: