Repository navigation
fix npm config and migrate from yarn to npm - #54
Merged
Merged
Conversation
odanado
commented
Sep 25, 2026
| "devEngines": { | ||
| "packageManager": { | ||
| "name": "npm", | ||
| "version": ">=11.16.0", |
Member
Author
There was a problem hiding this comment.
This is the minimum version that supports strict-allow-scripts=true.
| "esModuleInterop": true, | ||
| "resolveJsonModule": true | ||
| "resolveJsonModule": true, | ||
| "skipLibCheck": true |
Member
Author
There was a problem hiding this comment.
Upgrading @types/node to 24.x causes the following type errors in files such as @types/node/fs.d.ts.
error TS1165: A computed property name in an ambient context must refer to ... 'unique symbol'
error TS2339: Property 'dispose' does not exist on type 'SymbolConstructor'
error TS2304: Cannot find name 'Disposable'
This is because the TypeScript 4.x used in this repository does not have the type definitions for Symbol.dispose and similar. Upgrading to 5.2 or later would fix it, but for now I have enabled skipLibCheck to avoid the errors.
ref: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-2.html#using-declarations-and-explicit-resource-management
odanado
marked this pull request as ready for review
September 25, 2026 05:20
soranakahara
approved these changes
Sep 25, 2026
kazuma0129
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added
min-release-age=3andstrict-allow-scripts=trueto.npmrcas a countermeasure against supply chain attacks.We also migrated from yarn v1 to npm, because yarn v1 has no cooldown-related option.