Skip to content

Require authorization for legacy APIs - #825

Merged
vincent-olivert-riera merged 2 commits into
line:masterfrom
hoangpn:feature/require_authorization_for_legacy_apis
Nov 13, 2026
Merged

vincent-olivert-riera merged 2 commits into
line:masterfrom
hoangpn:feature/require_authorization_for_legacy_apis

Conversation

@hoangpn

@hoangpn hoangpn commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Legacy APIs are used for managing Prometheus configurations, such as retrieving all targets, URLs, or reloading configurations. These actions are critical and should not be accessible to regular users. Therefore, we have implemented new permissions and now require appropriate authorization for each API to enhance their security.

@hoangpn
hoangpn force-pushed the feature/require_authorization_for_legacy_apis branch 3 times, most recently from 80d581e to 8523724 Compare November 12, 2026 05:47
Comment thread docs/user/api.rst Resolved
@hoangpn
hoangpn force-pushed the feature/require_authorization_for_legacy_apis branch from 8523724 to b5b1c1c Compare November 13, 2026 05:38
Comment thread promgen/urls.py Resolved
Promgen's legacy APIs previously inherited from the Django View class, functioning as
traditional APIs. We have now refactored them to inherit from the APIView class in the
rest.py file, allowing us to leverage the features of the Django REST Framework.
Legacy APIs are used for managing Prometheus configurations, such as retrieving all targets,
URLs, or reloading configurations. These actions are critical and should not be accessible to
regular users. Therefore, we have implemented new permissions and now require appropriate
authorization for each API to enhance their security.
@hoangpn
hoangpn force-pushed the feature/require_authorization_for_legacy_apis branch from b5b1c1c to 93734f9 Compare November 13, 2026 05:46

@vincent-olivert-riera vincent-olivert-riera left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vincent-olivert-riera
vincent-olivert-riera merged commit 9bb0be8 into line:master Nov 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants