Skip to content

fix(ci): escape markdown backticks in promotion PR body#166

Merged
iamfj merged 1 commit into
nextfrom
fix/promotion-pr-body-backticks
Apr 23, 2026
Merged

fix(ci): escape markdown backticks in promotion PR body#166
iamfj merged 1 commit into
nextfrom
fix/promotion-pr-body-backticks

Conversation

@iamfj
Copy link
Copy Markdown
Member

@iamfj iamfj commented Apr 23, 2026

Summary

  • fix escaping in .github/workflows/promote-next-to-main.yml PR body generation
  • prevent bash command substitution from eating next/main/version markdown snippets

Why

Promotion PR body rendered placeholders as \ because workflow used over-escaped backticks (`\``), which bash interpreted as command substitution.

Validation

  • reproduced shell output before fix (next: command not found, main: command not found)
  • verified corrected output now renders markdown backticks as expected

@iamfj iamfj force-pushed the fix/promotion-pr-body-backticks branch from b86a45d to 21d31c7 Compare April 23, 2026 07:49
@iamfj iamfj merged commit d21a671 into next Apr 23, 2026
10 checks passed
@iamfj iamfj deleted the fix/promotion-pr-body-backticks branch April 23, 2026 07:50
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b86a45d4c9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .releaserc.cjs Outdated
publishCmd:
'npx clean-publish --access public --tag $( [ "$GITHUB_REF_NAME" = "next" ] && echo next || echo latest ) -- --provenance',
},
{ publishCmd: "npx clean-publish --access public -- --provenance" },
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Publish prereleases on the next dist-tag

The release pipeline now runs from both main and next, but the configured publish command (npx clean-publish --access public -- --provenance) does not set a dist-tag, so npm will use its default latest tag. That means next branch prereleases (e.g. *-next.N) can be promoted to latest and become the default install for all users, which breaks the stable/prerelease channel separation described in this change. Use a branch-aware publish path (for example semantic-release’s npm publishing with channels, or an explicit --tag for prerelease runs).

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant