Skip to content

chore(commitlint): enforce stricter validation#185

Merged
iamfj merged 2 commits into
nextfrom
chore/issue-97-commitlint-rules
Apr 27, 2026
Merged

chore(commitlint): enforce stricter validation#185
iamfj merged 2 commits into
nextfrom
chore/issue-97-commitlint-rules

Conversation

@iamfj
Copy link
Copy Markdown
Member

@iamfj iamfj commented Apr 26, 2026

What does this PR do?

  • enforce stricter validation

Type of change

  • internal

Checklist

  • npm test

Testing

  • npm test

Notes for reviewers

  • CONTRIBUTING.md
  • commitlint.config.js

Related issues

@iamfj iamfj force-pushed the chore/issue-97-commitlint-rules branch from 38ba471 to 4cd611f Compare April 27, 2026 06:52
@iamfj iamfj changed the base branch from main to next April 27, 2026 06:52
@chatgpt-codex-connector
Copy link
Copy Markdown

💡 Codex Review

const result = await replyToDiscussion(ctx.gql, {
threadId: thread,
body: options.body,
});

P2 Badge Enforce issue-only scope in comments reply command

The comments domain is documented as an issue-only compatibility facade, but this call omits entityKind: "issue", so any valid root thread UUID (including project/initiative discussions) can be replied to through comments reply. In practice, that means legacy issue-comment automation can mutate non-issue discussions if IDs are mixed, which violates the command contract and can target unintended entities.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@iamfj iamfj force-pushed the chore/issue-97-commitlint-rules branch from 4cd611f to 705218f Compare April 27, 2026 09:25
@iamfj iamfj changed the title chore: tighten commitlint enforcement and PR validation chore(commitlint): enforce stricter validation Apr 27, 2026
@iamfj
Copy link
Copy Markdown
Member Author

iamfj commented Apr 27, 2026

Addressed the review feedback by passing entityKind: "issue" from comments reply to replyToDiscussion, so the deprecated compatibility facade only accepts issue discussion threads. Added/updated command coverage for that delegation.\n\nValidation:\n- npm run check:ci\n- npx tsc --noEmit\n- npx vitest run tests/unit/commands/comments.test.ts\n- npm test

@iamfj iamfj merged commit 9effd26 into next Apr 27, 2026
9 checks passed
@iamfj iamfj deleted the chore/issue-97-commitlint-rules branch April 27, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Strengthen commitlint validation rules

1 participant