Windows: file open dialog multiselect fix#2332
Open
ppykalo wants to merge 8 commits intolinebender:masterfrom
Open
Windows: file open dialog multiselect fix#2332ppykalo wants to merge 8 commits intolinebender:masterfrom
ppykalo wants to merge 8 commits intolinebender:masterfrom
Conversation
xStrom
added
shell/win
xStrom
reviewed
Jan 16, 2023
Member
xStrom
left a comment
xStrom
left a comment
There was a problem hiding this comment.
Thanks for taking this on. For now I have just a few minor notes. I'll do a deeper review later.
| - X11: window focus events ([#1938] by [@Maan2003] | ||
| - Preserve the aspect ratio of a clipped region in an Image ([#2195] by [@barsae]) | ||
| - GTK: Hot state now properly resets when the mouse leaves the window via an occluded part. ([#2324] by [@xStrom]) | ||
| - Windows: generate `commands::OPEN_FILES` when using multiselect in file open dialog. ([#2332] by [@ppykalo]) |
Member
There was a problem hiding this comment.
Unfortunately the links aren't autogenerated. Please manually define [#2332] at the bottom of the file.
| path: os_str.into(), | ||
| .map(|s| FileInfo { | ||
| // `get_file_dialog_path` guarantees that save dialogs | ||
| // only return on path |
Member
There was a problem hiding this comment.
Suggested change
| // only return on path | |
| // only return one path |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using multi selection option for
SHOW_OPEN_PANELcommand on Windows correctly generatescommands::OPEN_FILESnow. Previouslycommands::OPEN_PANEL_CANCELLEDwas generated when more than one file was selected.