Change the default behavior of the ValueTextBox.#2379
Open
Jeremiah-Roise wants to merge 3 commits intolinebender:masterfrom
Open
Change the default behavior of the ValueTextBox.#2379Jeremiah-Roise wants to merge 3 commits intolinebender:masterfrom
Jeremiah-Roise wants to merge 3 commits intolinebender:masterfrom
Conversation
…pdate_value_while_editing default to true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it would be far more intuitive if this was true by default because it would function more like a normal TextBox.
I was working on adding auto complete to a project of mine, and it was working great until I tried to add it to a ValueTextBox, I spent hours trying to figure out what was wrong with my Formmatter impl because I assumed there was some type of event or command that I should have passed on. Long story short eventually I found the update_value_while_editing function and was able to fix my problem.
thanks for your time and listening to my rant.